diff options
| author | Hiroshi Yamauchi <yamauchi@google.com> | 2014-08-28 14:55:56 -0700 |
|---|---|---|
| committer | Hiroshi Yamauchi <yamauchi@google.com> | 2014-08-28 15:08:54 -0700 |
| commit | 7895d554d17309db67737b6750c59d8cece213e3 (patch) | |
| tree | cf4cadff03997851247f9be8559cb739e4bb026b /runtime/native/java_lang_Thread.cc | |
| parent | 79e909bc9d95c3952be85af846ba8bda344531f5 (diff) | |
Fix an assert failure in art::DumpNativeStack().
When ThreadList::SuspendAll() times out (and aborts),
UnsafeLogFatalForThreadSuspendAllTimeout() will call
art::DumpNativeStack() but it does not have the mutator lock
shared-locked (as it failed while trying to exclusive-lock the mutator
lock) and the AssertSharedHeld() on the mutator lock fails. It's an
assert failure nested in an time-out abort.
This change avoids it by letting it print the native method frame info
only if the thread has a shared lock on the mutator lock, as opposed
to asserting that it has a shared lock.
Change-Id: I17851ebcaa37f4f67086c15243a2cffea3997a02
Diffstat (limited to 'runtime/native/java_lang_Thread.cc')
0 files changed, 0 insertions, 0 deletions