diff options
| author | Alex Light <allight@google.com> | 2017-06-29 11:59:50 -0700 |
|---|---|---|
| committer | Alex Light <allight@google.com> | 2017-06-30 14:24:56 +0000 |
| commit | 46f9340f2a055a8fdfebbfbb739c697c20d83e7c (patch) | |
| tree | acb172f74723e4ea9ac7ded73b94c661217ec90d /runtime/native/java_lang_Thread.cc | |
| parent | fe9a4f061841a3c597aac6817a47c799c54fcad7 (diff) | |
Add SuspendReason enum and change Suspension functions.
More self-documenting and more type safe.
Bug: 62821960
Test: ./test.py
Change-Id: Ic7a1ae6a25e687d65f5aa10c1aad54a7b80dd086
Diffstat (limited to 'runtime/native/java_lang_Thread.cc')
| -rw-r--r-- | runtime/native/java_lang_Thread.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/runtime/native/java_lang_Thread.cc b/runtime/native/java_lang_Thread.cc index e4d1705d28..8b76327fa8 100644 --- a/runtime/native/java_lang_Thread.cc +++ b/runtime/native/java_lang_Thread.cc @@ -146,13 +146,16 @@ static void Thread_nativeSetName(JNIEnv* env, jobject peer, jstring java_name) { ThreadList* thread_list = Runtime::Current()->GetThreadList(); bool timed_out; // Take suspend thread lock to avoid races with threads trying to suspend this one. - Thread* thread = thread_list->SuspendThreadByPeer(peer, true, false, &timed_out); + Thread* thread = thread_list->SuspendThreadByPeer(peer, + /* request_suspension */ true, + SuspendReason::kInternal, + &timed_out); if (thread != nullptr) { { ScopedObjectAccess soa(env); thread->SetThreadName(name.c_str()); } - thread_list->Resume(thread, false); + thread_list->Resume(thread, SuspendReason::kInternal); } else if (timed_out) { LOG(ERROR) << "Trying to set thread name to '" << name.c_str() << "' failed as the thread " "failed to suspend within a generous timeout."; |