diff options
author | Martin Stjernholm <mast@google.com> | 2021-05-27 20:54:22 +0100 |
---|---|---|
committer | Martin Stjernholm <mast@google.com> | 2021-06-09 17:02:34 +0100 |
commit | 07f5e96d63121165b82635b6b7fa187ec3920612 (patch) | |
tree | 90ccf13b6bda6eb2e5d80c9a7db79d4e8116ff7e /libnativebridge/tests/NativeBridge3GetError_test.cpp | |
parent | 55309dbfe91c3bf3e9b8da24c002ad52deb3c5e5 (diff) |
Fix bitrot in the libnativebridge tests.
- Bitrot 1: NativeBridge2Signal_test stopped working when version 3 was
added in https://r.android.com/234059.
- Bitrot 2: The code path that PreInitializeNativeBridgeFail1_test
tested was removed completely when missing app data directory was
allowed in https://r.android.com/1208629, so delete the test.
- Use cc_test_library for the dynamic test libs so they are installed in
the test directory rather than in system/lib(64).
- Use test_per_src since native_bridge.cc doesn't support reloading the
native bridge implementation lib after unloading.
- Add a custom script to run the tests and a preupload check that the
script is run. (Configuring atest for these tests still TBD in
b/189484095 - test_per_src is a complication.)
Cherry-picked from https://r.android.com/1721410.
Test: art/libnativebridge/tests/runtests.sh
Bug: 122710865
Bug: 189484095
Change-Id: Ib2b387e1d858127ca4bb44c548a5105ea8b838d8
Merged-In: Ib2b387e1d858127ca4bb44c548a5105ea8b838d8
Diffstat (limited to 'libnativebridge/tests/NativeBridge3GetError_test.cpp')
-rw-r--r-- | libnativebridge/tests/NativeBridge3GetError_test.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libnativebridge/tests/NativeBridge3GetError_test.cpp b/libnativebridge/tests/NativeBridge3GetError_test.cpp index b6b315db06..afd0a7d511 100644 --- a/libnativebridge/tests/NativeBridge3GetError_test.cpp +++ b/libnativebridge/tests/NativeBridge3GetError_test.cpp @@ -18,8 +18,6 @@ namespace android { -constexpr const char* kNativeBridgeLibrary3 = "libnativebridge3-test-case.so"; - TEST_F(NativeBridgeTest, V3_GetError) { // Init ASSERT_TRUE(LoadNativeBridge(kNativeBridgeLibrary3, nullptr)); |