diff options
author | Calin Juravle <calin@google.com> | 2021-04-05 19:31:30 +0000 |
---|---|---|
committer | Calin Juravle <calin@google.com> | 2021-04-05 20:57:07 +0000 |
commit | 8b07c653a7e45886ee92d8a12aa439e98e84befa (patch) | |
tree | d204054a2b7b07769384db6f3c68ff53f7dccb3b /libartbase | |
parent | 50419f2d4ce9bef92115342692a405f30600e114 (diff) |
Revert "[metrics] Report CompilationReason and CompilerFilter"
This reverts commit f9bf4efcab3d05b6d547e492075de377400d2d88.
Reason for revert: b/184402526
Change-Id: Id297ef1db997d185bcd6f910cc6c84a62e6eaa0d
Diffstat (limited to 'libartbase')
-rw-r--r-- | libartbase/base/metrics/metrics.h | 92 | ||||
-rw-r--r-- | libartbase/base/metrics/metrics_common.cc | 38 |
2 files changed, 12 insertions, 118 deletions
diff --git a/libartbase/base/metrics/metrics.h b/libartbase/base/metrics/metrics.h index 316eb7a1a8..4e3346a763 100644 --- a/libartbase/base/metrics/metrics.h +++ b/libartbase/base/metrics/metrics.h @@ -83,14 +83,8 @@ enum class CompilationReason { kError, kUnknown, kFirstBoot, - kBootAfterOTA, - kPostBoot, + kBoot, kInstall, - kInstallFast, - kInstallBulk, - kInstallBulkSecondary, - kInstallBulkDowngraded, - kInstallBulkSecondaryDowngraded, kBgDexopt, kABOTA, kInactive, @@ -101,90 +95,28 @@ enum class CompilationReason { constexpr const char* CompilationReasonName(CompilationReason reason) { switch (reason) { case CompilationReason::kError: - return "error"; + return "Error"; case CompilationReason::kUnknown: - return "unknown"; + return "Unknown"; case CompilationReason::kFirstBoot: - return "first-boot"; - case CompilationReason::kBootAfterOTA: - return "boot-after-ota"; - case CompilationReason::kPostBoot: - return "post-boot"; + return "FirstBoot"; + case CompilationReason::kBoot: + return "Boot"; case CompilationReason::kInstall: - return "install"; - case CompilationReason::kInstallFast: - return "install-fast"; - case CompilationReason::kInstallBulk: - return "install-bulk"; - case CompilationReason::kInstallBulkSecondary: - return "install-bulk-secondary"; - case CompilationReason::kInstallBulkDowngraded: - return "install-bulk-downgraded"; - case CompilationReason::kInstallBulkSecondaryDowngraded: - return "install-bulk-secondary-downgraded"; + return "Install"; case CompilationReason::kBgDexopt: - return "bg-dexopt"; + return "BgDexopt"; case CompilationReason::kABOTA: - return "ab-ota"; + return "ABOTA"; case CompilationReason::kInactive: - return "inactive"; + return "Inactive"; case CompilationReason::kShared: - return "shared"; + return "Shared"; case CompilationReason::kInstallWithDexMetadata: - return "install-with-dex-metadata"; + return "InstallWithDexMetadata"; } } -constexpr CompilationReason CompilationReasonFromName(std::string_view name) { - // Names come from PackageManagerServiceCompilerMapping.java - if (name == "unknown") { - return CompilationReason::kUnknown; - } - if (name == "first-boot") { - return CompilationReason::kFirstBoot; - } - if (name == "boot-after-ota") { - return CompilationReason::kBootAfterOTA; - } - if (name == "post-boot") { - return CompilationReason::kPostBoot; - } - if (name == "install") { - return CompilationReason::kInstall; - } - if (name == "install-fast") { - return CompilationReason::kInstallFast; - } - if (name == "install-bulk") { - return CompilationReason::kInstallBulk; - } - if (name == "install-bulk-secondary") { - return CompilationReason::kInstallBulkSecondary; - } - if (name == "install-bulk-downgraded") { - return CompilationReason::kInstallBulkDowngraded; - } - if (name == "install-bulk-secondary-downgraded") { - return CompilationReason::kInstallBulkSecondaryDowngraded; - } - if (name == "bg-dexopt") { - return CompilationReason::kBgDexopt; - } - if (name == "ab-ota") { - return CompilationReason::kABOTA; - } - if (name == "inactive") { - return CompilationReason::kInactive; - } - if (name == "shared") { - return CompilationReason::kShared; - } - if (name == "install-with-dex-metadata") { - return CompilationReason::kInstallWithDexMetadata; - } - return CompilationReason::kError; -} - // SessionData contains metadata about a metrics session (basically the lifetime of an ART process). // This information should not change for the lifetime of the session. struct SessionData { diff --git a/libartbase/base/metrics/metrics_common.cc b/libartbase/base/metrics/metrics_common.cc index 7805f51c0a..89d003a71e 100644 --- a/libartbase/base/metrics/metrics_common.cc +++ b/libartbase/base/metrics/metrics_common.cc @@ -179,44 +179,6 @@ void FileBackend::EndReport() { } } -// Make sure CompilationReasonName and CompilationReasonForName are inverses. -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kError)) == - CompilationReason::kError); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kUnknown)) == - CompilationReason::kUnknown); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kFirstBoot)) == - CompilationReason::kFirstBoot); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kBootAfterOTA)) == - CompilationReason::kBootAfterOTA); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kPostBoot)) == - CompilationReason::kPostBoot); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstall)) == - CompilationReason::kInstall); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstallFast)) == - CompilationReason::kInstallFast); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstallBulk)) == - CompilationReason::kInstallBulk); -static_assert( - CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstallBulkSecondary)) == - CompilationReason::kInstallBulkSecondary); -static_assert( - CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstallBulkDowngraded)) == - CompilationReason::kInstallBulkDowngraded); -static_assert(CompilationReasonFromName( - CompilationReasonName(CompilationReason::kInstallBulkSecondaryDowngraded)) == - CompilationReason::kInstallBulkSecondaryDowngraded); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kBgDexopt)) == - CompilationReason::kBgDexopt); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kABOTA)) == - CompilationReason::kABOTA); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kInactive)) == - CompilationReason::kInactive); -static_assert(CompilationReasonFromName(CompilationReasonName(CompilationReason::kShared)) == - CompilationReason::kShared); -static_assert( - CompilationReasonFromName(CompilationReasonName(CompilationReason::kInstallWithDexMetadata)) == - CompilationReason::kInstallWithDexMetadata); - } // namespace metrics } // namespace art |