diff options
| author | Alex Light <allight@google.com> | 2020-11-16 16:54:01 +0000 |
|---|---|---|
| committer | Alex Light <allight@google.com> | 2020-11-18 20:26:53 +0000 |
| commit | 86fe9b85c5243debe5f695c1625bae03bf738452 (patch) | |
| tree | 5de78b8292a0225b617e1825817cbd12b46b6fa3 /compiler/optimizing/optimizing_compiler_stats.h | |
| parent | cc9df4fa1e666b90c5dd8eac94773763f8421f1e (diff) | |
Revert^4 "Partial LSE analysis & store removal"
We incorrectly handled merging unknowns in some situations.
Specifically in cases where we are unable to materialize loop-phis we
could end up with PureUnknowns which could end up hiding stores that
need to be kept.
In an unrelated issue we were incorrectly considering some values as
escapes when live at the point of an invoke. Since
SearchPhiPlaceholdersForKeptStores used a more precise notion of
escapes we could end up removing stores without being able to replace
the values.
This reverts commit 2316b3a0779f3721a78681f5c70ed6624ecaebef.
This unreverts commit b6837f0350ff66c13582b0e94178dd5ca283ff0a
This reverts commit fe270426c8a2a69a8f669339e83b86fbf40e25a1.
This unreverts commit bb6cda60e4418c0ab557ea4090e046bed8206763.
Bug: 67037140
Bug: 173120044
Reason for revert: Fixed issue causing incorrect store elimination
Test: ./test.py --host
Test: Boot cuttlefish
atest FrameworksServicesTests:com.android.server.job.BackgroundRestrictionsTest#testPowerWhiteList
Change-Id: I2ebae9ccfaf5169d551c5019b547589d0fce1dc9
Diffstat (limited to 'compiler/optimizing/optimizing_compiler_stats.h')
| -rw-r--r-- | compiler/optimizing/optimizing_compiler_stats.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/compiler/optimizing/optimizing_compiler_stats.h b/compiler/optimizing/optimizing_compiler_stats.h index 475c53205f..4322eb72a0 100644 --- a/compiler/optimizing/optimizing_compiler_stats.h +++ b/compiler/optimizing/optimizing_compiler_stats.h @@ -108,6 +108,11 @@ enum class MethodCompilationStat { kConstructorFenceRemovedCFRE, kBitstringTypeCheck, kJitOutOfMemoryForCommit, + kFullLSEAllocationRemoved, + kFullLSEPossible, + kNonPartialLoadRemoved, + kPartialLSEPossible, + kPartialStoreRemoved, kLastStat }; std::ostream& operator<<(std::ostream& os, MethodCompilationStat rhs); |