diff options
| author | Evgeny Astigeevich <evgeny.astigeevich@linaro.org> | 2020-06-12 10:51:43 +0100 |
|---|---|---|
| committer | Nicolas Geoffray <ngeoffray@google.com> | 2020-06-17 08:00:58 +0000 |
| commit | 6587d9110bd7f836e43db16f3f676da996218aef (patch) | |
| tree | 437d06a8e60fd70aaafaf2b167dfe636a303c68a /compiler/optimizing/optimization.h | |
| parent | 1912a5c7b9400009e361b0db52da77cc78f1cd77 (diff) | |
ART: Simplify HRem to reuse existing HDiv
A pattern seen in libcore and SPECjvm2008 workloads is a pair of HRem/HDiv
having the same dividend and divisor. The code generator processes
them separately and generates duplicated instructions calculating HDiv.
This CL adds detection of such a pattern to the instruction simplifier.
This optimization affects HInductionVarAnalysis and HLoopOptimization
preventing some loop optimizations. To avoid this the instruction simplifier
has the loop_friendly mode which means not to optimize HRems if they are in a loop.
A microbenchmark run on Pixel 3 shows the following improvements:
| little cores | big cores
arm32 Int32 | +21% | +40%
arm32 Int64 | +46% | +44%
arm64 Int32 | +27% | +14%
arm64 Int64 | +33% | +27%
Test: 411-checker-instruct-simplifier-hrem
Test: test.py --host --optimizing --jit --gtest --interpreter
Test: test.py --target --optimizing --jit --interpreter
Test: run-gtests.sh
Change-Id: I376a1bd299d7fe10acad46771236edd5f85dfe56
Diffstat (limited to 'compiler/optimizing/optimization.h')
| -rw-r--r-- | compiler/optimizing/optimization.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/compiler/optimizing/optimization.h b/compiler/optimizing/optimization.h index 4a515bcc90..f8aea9680d 100644 --- a/compiler/optimizing/optimization.h +++ b/compiler/optimizing/optimization.h @@ -66,6 +66,7 @@ class HOptimization : public ArenaObject<kArenaAllocOptimization> { // field is preferred over a string lookup at places where performance matters. // TODO: generate this table and lookup methods below automatically? enum class OptimizationPass { + kAggressiveInstructionSimplifier, kBoundsCheckElimination, kCHAGuardOptimization, kCodeSinking, |