diff options
| author | Alex Light <allight@google.com> | 2021-01-22 14:05:13 +0000 |
|---|---|---|
| committer | Alex Light <allight@google.com> | 2021-01-22 07:15:51 -0800 |
| commit | fc1ce4e8be0d977e3d41699f5ec746d68f63c024 (patch) | |
| tree | b656aa7c9e62aa181dfbf7fd4f2a0d32b8bf0704 /compiler/optimizing/loop_analysis.cc | |
| parent | c6da1be58086e873c9695f8c4c1a3a8ca718696e (diff) | |
Revert^2 "Partial Load Store Elimination"
This reverts commit 47ac53100303e7e864b7f6d65f17b23088ccf1d6.
There was a bug in LSE where we would incorrectly record the
shadow$_monitor_ field as not having a default initial value. This
caused partial LSE to be unable to compile the Object.identityHashCode
function, causing crashes. This issue was fixed in a parent CL. Also
updated all Offsets in LSE_test to be outside of the object header
regardless of configuration.
Test: ./test.py --host
Bug: 67037140
Reason for revert: Fixed issue with shadow$_monitor_ field and offsets
Change-Id: I4fb2afff4d410da818db38ed833927dfc0f6be33
Diffstat (limited to 'compiler/optimizing/loop_analysis.cc')
| -rw-r--r-- | compiler/optimizing/loop_analysis.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/optimizing/loop_analysis.cc b/compiler/optimizing/loop_analysis.cc index 78505171cb..a776c37f36 100644 --- a/compiler/optimizing/loop_analysis.cc +++ b/compiler/optimizing/loop_analysis.cc @@ -214,6 +214,9 @@ class X86_64LoopHelper : public ArchDefaultLoopHelper { return 3; case HInstruction::InstructionKind::kIf: return 2; + case HInstruction::InstructionKind::kPredicatedInstanceFieldGet: + // test + cond-jump + IFieldGet + return 4; case HInstruction::InstructionKind::kInstanceFieldGet: return 2; case HInstruction::InstructionKind::kInstanceFieldSet: |