summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_visualizer.cc
diff options
context:
space:
mode:
authorAlex Light <allight@google.com>2018-02-05 11:08:08 -0800
committerAlex Light <allight@google.com>2018-02-05 21:38:23 +0000
commitfe2a39d1a4297b3eb3bbf5d5af3eae8172b8c4db (patch)
treec699bf7e60338776103c5669927d6801d8e34dce /compiler/optimizing/graph_visualizer.cc
parent6db9a6c240e0ef4c69448c7806c5d035b7b5b111 (diff)
Revert "Temporarily disable lazy class-file-load-hook"
An ASAN failure was caused by a rare interaction between the fault-handler and updating the internal book-keeping for the ClassFileLoadHook. When we update the current definition for the ClassFileLoadHook we check to see if the definition has actually changed. This causes a read from the previous dex-file buffer. If the buffer is lazy and the agent never accessed it (very rare outside of testing) the SEGV will occur within art code in the kRunnable state. This caused the runtime to think the SEGV was coming from java code and perform some illegal reads prior to figuring out that the SEGV did not come from java. To fix this we simply make sure all the code that can cause the SEGV occurs while the runtime is in kNative state. We add an assert for this in the fault handler itself. Reason for revert: Fixed issue causing ASAN failure with lazy dex-file load hook. This reverts commit 37977705dc6cfa3e77299ae97675f80b59f2fcf0. Bug: 72909916 Test: ./test/testrunner/run-_build_test_target.py -j50 art-asan Change-Id: I8b2d2fda8092a379e0019db15ec360a5a63d8b3f
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions