diff options
author | Mathieu Chartier <mathieuc@google.com> | 2014-08-23 13:56:03 -0700 |
---|---|---|
committer | Mathieu Chartier <mathieuc@google.com> | 2014-08-26 11:02:08 -0700 |
commit | e4927f6654b7eda672312898e1fd3fecccacd6aa (patch) | |
tree | daca135aa7681a8ad210aa3a4f3f8db67e914a46 /compiler/optimizing/graph_visualizer.cc | |
parent | 0b05ec674139c2b2e0914b0bb0e1898f93a9c852 (diff) |
Fix race condition in TransitionCollector.
There was a minor race condition that could happen if multiple
threads called TransitionCollector at the same time. Starting out
in CMS:
Thread 1: TransitionCollector(SS).
Thread 2: TransitionCollector(CMS) sees that it is already CMS so
has copying_transition == false. But then thread 2 changes to SS.
Thread 1 resumes but incorrectly doesn't check the
disable_moving_gc_count_ possibly resulting in errors if
disable_moving_gc_count_ != 0 due to JNI since we are going from
SS -> CMS and are goign to move objects.
(cherry picked from commit de2233bbf64c7dde96513a729f6a97aebc2f0424)
Change-Id: I2fdda85f7cb7cbb0df3d1466a3c74853c5304c1b
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions