diff options
| author | David Brazdil <dbrazdil@google.com> | 2015-05-15 16:01:59 +0100 |
|---|---|---|
| committer | David Brazdil <dbrazdil@google.com> | 2015-05-15 16:50:23 +0100 |
| commit | c57397b2b87c7e6f28f4eee3c996d091e7dc0b01 (patch) | |
| tree | 51ef8e6126cb41174f6103700c5f5442a38bbfe5 /compiler/optimizing/graph_visualizer.cc | |
| parent | 06675720cc274eb9d91a4ecd3fb1eef94a2d88f0 (diff) | |
ART: Print C1vis lists as [v1,...,vN]
Checker interprets whitespace as a don't-care placeholder, making it
easier to write assertions which test only parts of the output (e.g.
"//CHECK: Add liveness:44" does not test the inputs or any other
attributes apart from "liveness").
However, since the GraphVisualizer prints lists with elements
separated by spaces ("[ v1 ... vN ]"), this allows for false positives
caused by an occurrence elsewhere in the output. For example, the
assertion: "//CHECK: [ x y ]" will match "[ x y ]" but also
"[ x a y b ]" or even "[ x ] abc [ y ]".
Switching to comma-separated lists works around this issue.
This patch updates all test files, fixes one false positive that this
change revealed (test 442, line 337) and two occurrences of a wrong
match (test 462, lines 121, 149).
Bug: 21189305
Change-Id: I3b22503be3d92529dac0b13f66bccbcfabea6721
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
| -rw-r--r-- | compiler/optimizing/graph_visualizer.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/compiler/optimizing/graph_visualizer.cc b/compiler/optimizing/graph_visualizer.cc index e0a9c6f084..7ea1240c5e 100644 --- a/compiler/optimizing/graph_visualizer.cc +++ b/compiler/optimizing/graph_visualizer.cc @@ -58,7 +58,7 @@ class StringList { if (is_empty_) { is_empty_ = false; } else { - sstream_ << " "; + sstream_ << ","; } return sstream_; } @@ -71,7 +71,7 @@ class StringList { }; std::ostream& operator<<(std::ostream& os, const StringList& list) { - return os << "[ " << list.sstream_.str() << " ]"; + return os << "[" << list.sstream_.str() << "]"; } /** |