summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_visualizer.cc
diff options
context:
space:
mode:
authorAlex Light <allight@google.com>2018-01-26 09:46:32 -0800
committerAlex Light <allight@google.com>2018-01-26 09:46:32 -0800
commit81f75c3df1d54783ddb172d36da2049bf9d97d96 (patch)
tree4d4e68e2157aa96446f8c7188c13f6c7c539293d /compiler/optimizing/graph_visualizer.cc
parent3d2680b40f2ce2b726c2442d6163100aa1237651 (diff)
Make adbconnection validate jdwpOptions and change defaults
The (libjdwp) default argument values are not entirely compatible with adbconnection. This means that if you manually ran dalvikvm with -XjdwpProvider:adbconnection and no -XjdwpOptions the jdwp thread would deadlock. In order to prevent this from happening adbconnection will now validate that the explictly passed in parameters are usable and will add in required arguments automatically if they are not present. Test: dalvikvm -XjdwpProvider:adbconnection -cp testing.dex loop & adb forward tcp:12345 jdwp:<pid of dalvikvm> jdb -attach localhost:12345 Test: dalvikvm -XjdwpProvider:adbconnection \ -XjdwpOptions:server=n \ -cp testing.dex loop; ensure process exits and check logcat for error message. Change-Id: I8e26a9f4479ea8c324f741b9835bbc1fe8407047
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions