diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2016-03-16 11:25:29 -0700 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2016-03-16 13:29:18 -0700 |
| commit | 50e933188d993c6eb67560db1fcad67ba1d182e1 (patch) | |
| tree | b0712470920bb69e4823787afec07f37a6eea6bb /compiler/optimizing/graph_visualizer.cc | |
| parent | 8e57978b5f330a322f05644c2db7fa8ce89b1b46 (diff) | |
Fix race in AllocEntrypointsInstrumented
We were using the quick_alloc_entry_points_instrumentation_counter_,
this counter is updated before the threads are suspended. The
allocator could come out of a suspend point, see that threads are
supposedly still no instrumented, continue the allocation, then
suddenly quick_alloc_entry_points_instrumentation_counter_ becomes
1 and alloc_tracking_enabled_ becomes true resulting in a failing
DCHECK.
The fix is to add a boolean that is updated only when the threads
are suspended.
Bug: 27506909
(cherry picked from commit 77d993107773b7b9bd7f07ce08d0aaac1631bf84)
Change-Id: Id12983ef77c4fddb0394e4439ce0829777f1a70b
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions