summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_visualizer.cc
diff options
context:
space:
mode:
authorVladimir Marko <vmarko@google.com>2016-06-01 18:38:43 +0100
committerVladimir Marko <vmarko@google.com>2016-06-03 10:52:22 +0100
commit492a7fa6df3b197a24099a50f5abf624164f3842 (patch)
tree1c02e48c0a16c8ff91f189946a39a3f14c1048dc /compiler/optimizing/graph_visualizer.cc
parentf7e1ab5224e16a47a410a788915422c73abfffac (diff)
Delay dex-to-dex compilation until Optimizing is done.
This fixes a race between inlining in the Optimizing backend and dex-to-dex quickening where the Optimizing can read the non-quickened opcode and then the quickened field index or vtable index and look up the wrong field or method. Even if we such tearing of the dex instruction does not happen, the possible reordering of dex-to-dex and Optimizing compilation makes the final oat file non-deterministic. Also, remove VerificationResults::RemoveVerifiedMethod() as we have only the Optimizing backend now and as such it was dead code and would have interfered with this change. Bug: 29043547 Bug: 29089975 Change-Id: I8389927d35dcacaf2f99c2153f055857036c8129
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions