diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2015-10-28 11:10:46 -0700 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2015-10-28 15:42:42 -0700 |
| commit | 41af5e50d0b5e9d13084a61cfe9dfa6b6e201a40 (patch) | |
| tree | d8c47581bf110021fa10c05351d33c5f873e11e3 /compiler/optimizing/graph_visualizer.cc | |
| parent | 13f6af0f9c8af1fce34e9610ad9d30d4d0434478 (diff) | |
Store method as ArtMethod* instead of jmethodId in Breakpoint
Previously we needed a ScopedObjectAccess for Dbg::VisitRoots,
this could cause deadlocks in the following scenario:
GC:
Goes to runnable state while holding mutator lock as shared held.
This occurred in Dbg::VisitRoots when calling Breakpoint::Method.
Other thread:
Calls SuspendAll and suspends the GC thread before it can go back
to suspended thread state. This thread then attempts to exclusive
lock mutator lock, but the GC is suspended while holding it in a
shared state.
Bug: 25336094
Change-Id: Idcb8d34c314b1d6951abe533a0cfa586cc07d7d6
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions