diff options
| author | David Brazdil <dbrazdil@google.com> | 2018-04-23 13:51:16 +0100 |
|---|---|---|
| committer | David Brazdil <dbrazdil@google.com> | 2018-05-08 10:32:37 +0100 |
| commit | 39512f5ac08fb8b567336d7c3874065fce062ce7 (patch) | |
| tree | 71a972a6091ec457a8e94c2b5ffac20bb25c1240 /compiler/optimizing/graph_visualizer.cc | |
| parent | 166546c3579b7a9deb413f8e44ad94b8ed41335b (diff) | |
Fix race in hidden_api.h
The hidden API decision logic can dedupe warnings by changing the
access flags of a previously warned about method to whitelist, thus
exiting early on the next attempt to access it. This logic had a race
in it, because it would decode the flags, make a decision and then
decode them again when printing a warning. If another thread changed
the flags in between, the warning would say "whitelist".
Change the code so that the hidden API flags are decoded only once.
This may still result in multiple warnings about the same API, but at
least the messages will be consistent.
Bug: 78327881
Bug: 64382372
Test: none
Merged-In: I956dd56536bdfce492845e6a90fdcbe29c2676b5
Change-Id: I956dd56536bdfce492845e6a90fdcbe29c2676b5
(cherry picked from commit b8c6619f16348403c3933d9e425b4b8c80af5389)
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions