diff options
| author | Nicolas Geoffray <ngeoffray@google.com> | 2021-04-19 08:46:32 +0100 |
|---|---|---|
| committer | Nicolas Geoffray <ngeoffray@google.com> | 2021-04-19 12:43:16 +0000 |
| commit | 0744d72e304fddd5453d05f8e06fa85c0467e86d (patch) | |
| tree | 25ed932d34a9a440acdda406cdd580d9a74b7e94 /compiler/optimizing/graph_visualizer.cc | |
| parent | 0b943287e7dec0cbe1734752f5a1f30f3c29973b (diff) | |
Fix race in GetPrimaryOatFile.
GetPrimaryOatFile is broken and racy:
- Broken as it returns the first entry of a set, which isn't guaranteed
to be the primary oat file.
- Racy as is returns an .oat file and then drops the oat_file_manager lock,
so the OatFile may be concurrently deleted.
This CL fixes the race by only returning the information needed by the
only user of GetPrimaryOatFile.
Test: test.py
Change-Id: I512cb82a1c8856c06abf9bb243a5eeee33701dd1
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions