summaryrefslogtreecommitdiff
path: root/compiler/optimizing/graph_visualizer.cc
diff options
context:
space:
mode:
authorandroid-build-team Robot <android-build-team-robot@google.com>2020-02-22 03:24:01 +0000
committerandroid-build-team Robot <android-build-team-robot@google.com>2020-02-22 03:24:01 +0000
commit02bdf4515cd7e8eaf93be40f6aea33abf53ab070 (patch)
treecb1a54ca80ad92291db601a2edb8e186116e97d3 /compiler/optimizing/graph_visualizer.cc
parent646ee4c27f96109e1a98d3ef45953aa367c77986 (diff)
parent870deedb27d064c6c3d63e5c2dd06bb2e036898c (diff)
Snap for 6227479 from 870deedb27d064c6c3d63e5c2dd06bb2e036898c to rvc-release
Change-Id: Iecb535f94b4e0ff251b96296e8b48c0fb31db570
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
-rw-r--r--compiler/optimizing/graph_visualizer.cc13
1 files changed, 8 insertions, 5 deletions
diff --git a/compiler/optimizing/graph_visualizer.cc b/compiler/optimizing/graph_visualizer.cc
index 9419c8dcf4..d94c1fa2fb 100644
--- a/compiler/optimizing/graph_visualizer.cc
+++ b/compiler/optimizing/graph_visualizer.cc
@@ -113,16 +113,19 @@ class HGraphVisualizerDisassembler {
const uint8_t* base_address,
const uint8_t* end_address)
: instruction_set_(instruction_set), disassembler_(nullptr) {
- libart_disassembler_handle_ =
- dlopen(kIsDebugBuild ? "libartd-disassembler.so" : "libart-disassembler.so", RTLD_NOW);
+ constexpr const char* libart_disassembler_so_name =
+ kIsDebugBuild ? "libartd-disassembler.so" : "libart-disassembler.so";
+ libart_disassembler_handle_ = dlopen(libart_disassembler_so_name, RTLD_NOW);
if (libart_disassembler_handle_ == nullptr) {
- LOG(WARNING) << "Failed to dlopen libart-disassembler: " << dlerror();
+ LOG(ERROR) << "Failed to dlopen " << libart_disassembler_so_name << ": " << dlerror();
return;
}
+ constexpr const char* create_disassembler_symbol = "create_disassembler";
create_disasm_prototype* create_disassembler = reinterpret_cast<create_disasm_prototype*>(
- dlsym(libart_disassembler_handle_, "create_disassembler"));
+ dlsym(libart_disassembler_handle_, create_disassembler_symbol));
if (create_disassembler == nullptr) {
- LOG(WARNING) << "Could not find create_disassembler entry: " << dlerror();
+ LOG(ERROR) << "Could not find " << create_disassembler_symbol << " entry in "
+ << libart_disassembler_so_name << ": " << dlerror();
return;
}
// Reading the disassembly from 0x0 is easier, so we print relative