diff options
| author | Vladimir Marko <vmarko@google.com> | 2018-08-21 11:36:16 +0100 |
|---|---|---|
| committer | Vladimir Marko <vmarko@google.com> | 2018-08-21 11:49:43 +0100 |
| commit | 00cbb4113bd646df142406fa080ecc3e7687091b (patch) | |
| tree | a86056c7f4d0a2cd75fce122bb89d7badbaf1085 /compiler/optimizing/graph_visualizer.cc | |
| parent | e3f0656a1852b9fb619fdcb369755ea324767c0e (diff) | |
Avoid crash when ANDROID_DATA is not writeable.
In this situation, the `dalvik_cache` filename is non-empty
but the cache directory cannot be created, so the variable
`dalvik_cache_exists` is false triggering a wrong DCHECK().
We relax the DCHECK() and adjust related code.
The bug was introduced in
https://android-review.googlesource.com/734702 .
Also prevent running dex2oat if the cache does not exist,
the dex2oat would previously fail anyway due to the empty
--image= parameter.
Test: Extra test in image_space_test.
Test: m test-art-host-gtest
Test: testrunner.py --host --optimizing
Bug: 112848347
Bug: 112827048
Change-Id: Ib82a3885773e95a7bdb0835499ea564f31e75eea
Diffstat (limited to 'compiler/optimizing/graph_visualizer.cc')
0 files changed, 0 insertions, 0 deletions