summaryrefslogtreecommitdiff
path: root/compiler/optimizing/codegen_test_utils.h
diff options
context:
space:
mode:
authorVladimir Marko <vmarko@google.com>2017-07-25 15:27:15 +0100
committerVladimir Marko <vmarko@google.com>2017-07-25 15:51:45 +0100
commit302f69cf7172d057c3ad9a8d4125a38e9dab8a71 (patch)
tree2924be212a990cd972d27bd352a248234e9b2a34 /compiler/optimizing/codegen_test_utils.h
parent86d1db15332571f21bd588efed0de3384269a1c5 (diff)
Fix race in artInvokeInterfaceTrampoline().
When artInvokeInterfaceTrampoline() didn't get a resolved interface method, it was calling FindMethodFromCode<>() where the interface method was resolved and then a virtual method for it was looked up. It then tried to retrieve the interface method from the DexCache where it would usualy be found as it was just stored there by the method resolution. However, another thread could have just evicted that entry. Instead of adding another call to LookupResolvedMethod(), use the fact that artInvokeInterfaceTrampoline() already explicitly inlines all the FindMethodFromCode<>() except for the interface method resolution, so we can simply do the resolution and then take the existing path for the rest of the work. Test: m test-art-host-gtest Test: testrunner.py --host Bug: 30627598 Change-Id: I62ca9c4e108ab6a3ee700b55d3b19c8f0f63f1d2
Diffstat (limited to 'compiler/optimizing/codegen_test_utils.h')
0 files changed, 0 insertions, 0 deletions