diff options
| author | David Srbecky <dsrbecky@google.com> | 2016-03-13 22:00:07 +0000 |
|---|---|---|
| committer | David Srbecky <dsrbecky@google.com> | 2016-03-16 17:24:17 +0000 |
| commit | 346dc993615487e9c645a515dfcbf9a6488f36fe (patch) | |
| tree | adf8006d2786c31cae282161491ab7c8f2cc3b2b /compiler/driver/compiler_options.h | |
| parent | fbc61e19578d281d05728bcd120e1ace57c2fbd8 (diff) | |
Remove --native-debuggable compiler option.
Check if both --debuggable and --generate-debug-info are set instead.
History: I have recently added the --native-debuggable flag to control
whether extra stack maps are generated in order to produce accurate
native line number mapping of all generated code. I didn't want to
include it into --debuggable since we compile boot.oat as debuggable
and so it would be affected.
On second thought, it would have been reasonable to generate the extra
stackmaps only if both --debuggable and --generate-debug-info are set,
instead of introducing another compiler flag. This means we do not
affect boot.oat but we still get the extra stack maps if DWARF debug
information is explicitly requested.
Change-Id: I7e5e557e4850a88b3b6f86178d2cb645fb1e1110
Diffstat (limited to 'compiler/driver/compiler_options.h')
| -rw-r--r-- | compiler/driver/compiler_options.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/compiler/driver/compiler_options.h b/compiler/driver/compiler_options.h index 4db82a638d..fbfa7c85f1 100644 --- a/compiler/driver/compiler_options.h +++ b/compiler/driver/compiler_options.h @@ -49,7 +49,6 @@ class CompilerOptions FINAL { static const size_t kDefaultTinyMethodThreshold = 20; static const size_t kDefaultNumDexMethodsThreshold = 900; static constexpr double kDefaultTopKProfileThreshold = 90.0; - static const bool kDefaultNativeDebuggable = false; static const bool kDefaultGenerateDebugInfo = false; static const bool kDefaultGenerateMiniDebugInfo = false; static const bool kDefaultIncludePatchInformation = false; @@ -179,7 +178,7 @@ class CompilerOptions FINAL { } bool GetNativeDebuggable() const { - return native_debuggable_; + return GetDebuggable() && GetGenerateDebugInfo(); } // This flag controls whether the compiler collects debugging information. @@ -292,7 +291,6 @@ class CompilerOptions FINAL { // When using a profile file only the top K% of the profiled samples will be compiled. double top_k_profile_threshold_; bool debuggable_; - bool native_debuggable_; bool generate_debug_info_; bool generate_mini_debug_info_; bool implicit_null_checks_; |