diff options
| author | David Srbecky <dsrbecky@google.com> | 2016-03-13 22:00:07 +0000 |
|---|---|---|
| committer | David Srbecky <dsrbecky@google.com> | 2016-03-16 17:24:17 +0000 |
| commit | 346dc993615487e9c645a515dfcbf9a6488f36fe (patch) | |
| tree | adf8006d2786c31cae282161491ab7c8f2cc3b2b /compiler/driver/compiler_options.cc | |
| parent | fbc61e19578d281d05728bcd120e1ace57c2fbd8 (diff) | |
Remove --native-debuggable compiler option.
Check if both --debuggable and --generate-debug-info are set instead.
History: I have recently added the --native-debuggable flag to control
whether extra stack maps are generated in order to produce accurate
native line number mapping of all generated code. I didn't want to
include it into --debuggable since we compile boot.oat as debuggable
and so it would be affected.
On second thought, it would have been reasonable to generate the extra
stackmaps only if both --debuggable and --generate-debug-info are set,
instead of introducing another compiler flag. This means we do not
affect boot.oat but we still get the extra stack maps if DWARF debug
information is explicitly requested.
Change-Id: I7e5e557e4850a88b3b6f86178d2cb645fb1e1110
Diffstat (limited to 'compiler/driver/compiler_options.cc')
| -rw-r--r-- | compiler/driver/compiler_options.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/compiler/driver/compiler_options.cc b/compiler/driver/compiler_options.cc index 3bf89214d7..43bdbf3d4d 100644 --- a/compiler/driver/compiler_options.cc +++ b/compiler/driver/compiler_options.cc @@ -35,7 +35,6 @@ CompilerOptions::CompilerOptions() include_patch_information_(kDefaultIncludePatchInformation), top_k_profile_threshold_(kDefaultTopKProfileThreshold), debuggable_(false), - native_debuggable_(kDefaultNativeDebuggable), generate_debug_info_(kDefaultGenerateDebugInfo), generate_mini_debug_info_(kDefaultGenerateMiniDebugInfo), implicit_null_checks_(true), @@ -92,7 +91,6 @@ CompilerOptions::CompilerOptions(CompilerFilter compiler_filter, include_patch_information_(include_patch_information), top_k_profile_threshold_(top_k_profile_threshold), debuggable_(debuggable), - native_debuggable_(kDefaultNativeDebuggable), generate_debug_info_(generate_debug_info), generate_mini_debug_info_(kDefaultGenerateMiniDebugInfo), implicit_null_checks_(implicit_null_checks), @@ -226,9 +224,6 @@ bool CompilerOptions::ParseCompilerOption(const StringPiece& option, UsageFn Usa generate_mini_debug_info_ = false; } else if (option == "--debuggable") { debuggable_ = true; - } else if (option == "--native-debuggable") { - native_debuggable_ = true; - debuggable_ = true; } else if (option.starts_with("--top-k-profile-threshold=")) { ParseDouble(option.data(), '=', 0.0, 100.0, &top_k_profile_threshold_, Usage); } else if (option == "--include-patch-information") { |