diff options
| author | David Sehr <sehr@google.com> | 2016-10-13 09:12:37 -0700 |
|---|---|---|
| committer | David Sehr <sehr@google.com> | 2016-10-18 14:10:04 -0700 |
| commit | 709b070044354d9f47641f273edacaeeb0240ab7 (patch) | |
| tree | 3a8ac051d7c35076303984d0d892cdd396b60427 /compiler/common_compiler_test.cc | |
| parent | 1a4de6a2453a3ad0310aca1a44e7e2d3b6f53bc1 (diff) | |
Remove mirror:: and ArtMethod deps in utils.{h,cc}
The latest chapter in the ongoing saga of attempting to dump a DEX
file without having to start a whole runtime instance. This episode
finds us removing references to ArtMethod/ArtField/mirror.
One aspect of this change that I would like to call out specfically
is that the utils versions of the "Pretty*" functions all were written
to accept nullptr as an argument. I have split these functions up as
follows:
1) an instance method, such as PrettyClass that obviously requires
this != nullptr.
2) a static method, that behaves the same way as the util method, but
calls the instance method if p != nullptr.
This requires using a full class qualifier for the static methods,
which isn't exactly beautiful. I have tried to remove as many cases
as possible where it was clear p != nullptr.
Bug: 22322814
Test: test-art-host
Change-Id: I21adee3614aa697aa580cd1b86b72d9206e1cb24
Diffstat (limited to 'compiler/common_compiler_test.cc')
| -rw-r--r-- | compiler/common_compiler_test.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/common_compiler_test.cc b/compiler/common_compiler_test.cc index bc8facdb41..51bf9ea3bd 100644 --- a/compiler/common_compiler_test.cc +++ b/compiler/common_compiler_test.cc @@ -86,7 +86,7 @@ void CommonCompilerTest::MakeExecutable(ArtMethod* method) { MakeExecutable(code_ptr, code.size()); const void* method_code = CompiledMethod::CodePointer(code_ptr, compiled_method->GetInstructionSet()); - LOG(INFO) << "MakeExecutable " << PrettyMethod(method) << " code=" << method_code; + LOG(INFO) << "MakeExecutable " << method->PrettyMethod() << " code=" << method_code; class_linker_->SetEntryPointsToCompiledCode(method, method_code); } else { // No code? You must mean to go into the interpreter. |