diff options
author | Roland Levillain <rpl@google.com> | 2018-05-24 13:19:05 +0000 |
---|---|---|
committer | Roland Levillain <rpl@google.com> | 2018-06-11 14:03:37 +0100 |
commit | 05e34f4cb8c9db165d1008721e874b9dd3db024b (patch) | |
tree | c41d397ef5cfb9d7918fceadcda3195a0d0d91de /cmdline | |
parent | 428d80e3a49f732b39bb0c71cfde26451e3fdf4d (diff) |
Revert^2 "Remove support for Valgrind in ART."
- Disable test configuration art-gtest-valgrind64
(art-gtest-valgrind32 was already disabled).
- Remove Makefile logic regarding testing with Valgrind.
- Remove occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_VALGRIND`.
- Replace occurrences of `TEST_DISABLED_FOR_MEMORY_TOOL_ASAN` with
`TEST_DISABLED_FOR_MEMORY_TOOL`.
- Replace the potentially dynamically evaluated
`RUNNING_ON_MEMORY_TOOL` expression with constant
`kRunningOnMemoryTool`.
- Simplify and fold the logic of
`art::ArenaAllocatorMemoryToolCheckImpl` and
`art::ArenaAllocatorMemoryToolCheck` into
`art::ArenaAllocatorMemoryTool`.
- Adjust comments regarding memory tools.
- Remove Valgrind suppression files.
- Remove `--callgrind` option from tools/art.
This reverts commit 8b362a87d52a6668ffd2283ef6ffc274315f41c8.
Change-Id: I23c76845e6ccf766f19b22b58a0d5161f60842a9
Test: art/test.py
Test: art/test/testrunner/run_build_test_target.py art-asan
Bug: 77856586
Bug: 29282211
Diffstat (limited to 'cmdline')
-rw-r--r-- | cmdline/unit.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/cmdline/unit.h b/cmdline/unit.h index ad6a03d12f..f73981fbd3 100644 --- a/cmdline/unit.h +++ b/cmdline/unit.h @@ -21,8 +21,9 @@ namespace art { // Used for arguments that simply indicate presence (e.g. "-help") without any values. struct Unit { - // Avoid 'Conditional jump or move depends on uninitialised value(s)' errors - // when running valgrind by specifying a user-defined constructor. + // Historical note: We specified a user-defined constructor to avoid + // 'Conditional jump or move depends on uninitialised value(s)' errors + // when running Valgrind. Unit() {} Unit(const Unit&) = default; ~Unit() {} |