summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNataniel Borges <natanieljr@google.com>2021-06-04 16:04:56 +0200
committerNataniel Borges <natanieljr@google.com>2021-06-04 16:04:56 +0200
commitf420024bf5136bceb1a47ca3b08b537611a0d797 (patch)
treedff76c00e494f2db2a4dbd22bdfaf329a06a2528
parent924618b41ccbe76c3bf21f1c172bdf6219760294 (diff)
Promote stable flicker tests (rotation)
The tests have been stable since last weeks when the underlying bugs were closed. Bug: 185401242 Bug: 185400889 Test: atest FlickerTests:com.android.server.wm.flicker.rotation Change-Id: I4aa13016f214f99bcff5adcd98e71096eacada2d
-rw-r--r--tests/FlickerTests/src/com/android/server/wm/flicker/rotation/ChangeAppRotationTest.kt26
-rw-r--r--tests/FlickerTests/src/com/android/server/wm/flicker/rotation/RotationTransition.kt8
-rw-r--r--tests/FlickerTests/src/com/android/server/wm/flicker/rotation/SeamlessAppRotationTest.kt15
3 files changed, 10 insertions, 39 deletions
diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/ChangeAppRotationTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/ChangeAppRotationTest.kt
index 1dbb617b21ba..69e8a8d08e58 100644
--- a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/ChangeAppRotationTest.kt
+++ b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/ChangeAppRotationTest.kt
@@ -55,7 +55,7 @@ class ChangeAppRotationTest(
}
}
- @FlakyTest(bugId = 151179149)
+ @FlakyTest(bugId = 190185577)
@Test
override fun focusDoesNotChange() {
super.focusDoesNotChange()
@@ -63,12 +63,6 @@ class ChangeAppRotationTest(
@Postsubmit
@Test
- override fun noUncoveredRegions() {
- super.noUncoveredRegions()
- }
-
- @FlakyTest
- @Test
fun screenshotLayerBecomesInvisible() {
testSpec.assertLayers {
this.isVisible(testApp.getPackage())
@@ -81,14 +75,8 @@ class ChangeAppRotationTest(
@Postsubmit
@Test
- override fun appLayerRotates_EndingPos() {
- super.appLayerRotates_EndingPos()
- }
-
- @Postsubmit
- @Test
- override fun appLayerRotates_StartingPos() {
- super.appLayerRotates_StartingPos()
+ override fun statusBarLayerRotatesScales() {
+ super.statusBarLayerRotatesScales()
}
@Presubmit
@@ -97,18 +85,12 @@ class ChangeAppRotationTest(
super.navBarWindowIsAlwaysVisible()
}
- @Postsubmit
+ @FlakyTest
@Test
override fun statusBarLayerIsAlwaysVisible() {
super.statusBarLayerIsAlwaysVisible()
}
- @Postsubmit
- @Test
- override fun statusBarWindowIsAlwaysVisible() {
- super.statusBarWindowIsAlwaysVisible()
- }
-
companion object {
private const val SCREENSHOT_LAYER = "RotationLayer"
diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/RotationTransition.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/RotationTransition.kt
index ab8ebd923fd3..4b888cd5aad0 100644
--- a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/RotationTransition.kt
+++ b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/RotationTransition.kt
@@ -88,7 +88,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
testSpec.config.startRotation, testSpec.config.endRotation)
}
- @FlakyTest
+ @Presubmit
@Test
open fun statusBarWindowIsAlwaysVisible() {
testSpec.statusBarWindowIsAlwaysVisible()
@@ -128,7 +128,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
}
}
- @FlakyTest
+ @Presubmit
@Test
open fun noUncoveredRegions() {
testSpec.noUncoveredRegions(testSpec.config.startRotation,
@@ -141,7 +141,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
testSpec.focusDoesNotChange()
}
- @FlakyTest
+ @Presubmit
@Test
open fun appLayerRotates_StartingPos() {
testSpec.assertLayersStart {
@@ -149,7 +149,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
}
}
- @FlakyTest
+ @Presubmit
@Test
open fun appLayerRotates_EndingPos() {
testSpec.assertLayersEnd {
diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/SeamlessAppRotationTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/SeamlessAppRotationTest.kt
index 462710711bca..b153bece1133 100644
--- a/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/SeamlessAppRotationTest.kt
+++ b/tests/FlickerTests/src/com/android/server/wm/flicker/rotation/SeamlessAppRotationTest.kt
@@ -17,6 +17,7 @@
package com.android.server.wm.flicker.rotation
import android.platform.test.annotations.Postsubmit
+import android.platform.test.annotations.Presubmit
import androidx.test.filters.FlakyTest
import androidx.test.filters.RequiresDevice
import com.android.server.wm.flicker.FlickerParametersRunnerFactory
@@ -71,13 +72,7 @@ class SeamlessAppRotationTest(
super.statusBarLayerIsAlwaysVisible()
}
- @FlakyTest(bugId = 185400889)
- @Test
- override fun noUncoveredRegions() {
- super.noUncoveredRegions()
- }
-
- @FlakyTest(bugId = 185400889)
+ @Presubmit
@Test
fun appLayerAlwaysVisible() {
testSpec.assertLayers {
@@ -97,12 +92,6 @@ class SeamlessAppRotationTest(
@Postsubmit
@Test
- override fun navBarWindowIsAlwaysVisible() {
- super.navBarWindowIsAlwaysVisible()
- }
-
- @Postsubmit
- @Test
override fun visibleLayersShownMoreThanOneConsecutiveEntry() {
super.visibleLayersShownMoreThanOneConsecutiveEntry()
}