summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Boehm <hboehm@google.com>2021-03-06 18:47:20 -0800
committerHans Boehm <hboehm@google.com>2021-03-06 18:47:20 -0800
commit5dc6b62136e03fd34ca6979369351198d23531b4 (patch)
treef02733cad0355f37356c34a5168d05b5b45d8a10
parentff07d10d0f0057fbc0a626834b8ef34296eab255 (diff)
No longer call registerNativeAllocation
The original rationale is obsolete, since contexts are now almost always shared. This call was unbalanced; there was no corresponding freeNativeAllocation call. Thus, in the rare cases in which this actually makes a difference, it's likely to lead to perpetually increasing native allocation counts, which is more likely to be confusing than helpful to the garbage collector. (Discussed with Tim and Jean-Luc, and concluded that it was best just to remove the code.) Test: Treehugger Bug: 181351667 Change-Id: I376a16732231aad0fdacd022de301464e5ac71dd
-rw-r--r--rs/java/android/renderscript/RenderScript.java7
1 files changed, 0 insertions, 7 deletions
diff --git a/rs/java/android/renderscript/RenderScript.java b/rs/java/android/renderscript/RenderScript.java
index 39efe731ce8a..806a25a748e2 100644
--- a/rs/java/android/renderscript/RenderScript.java
+++ b/rs/java/android/renderscript/RenderScript.java
@@ -1363,13 +1363,6 @@ public class RenderScript {
mApplicationContext = ctx.getApplicationContext();
}
mRWLock = new ReentrantReadWriteLock();
- try {
- registerNativeAllocation.invoke(sRuntime, 4 * 1024 * 1024); // 4MB for GC sake
- } catch (Exception e) {
- Log.e(RenderScript.LOG_TAG, "Couldn't invoke registerNativeAllocation:" + e);
- throw new RSRuntimeException("Couldn't invoke registerNativeAllocation:" + e);
- }
-
}
/**