summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndy Hung <hunga@google.com>2020-12-10 21:56:01 -0800
committerAndy Hung <hunga@google.com>2020-12-10 22:08:04 -0800
commit0a8c907f68d2913bfb7c160c9d481d65443fc1fd (patch)
treebf8cff34550280f6ad70a342cceefc0dc24fcd63
parent7db7b68b9daa6e8ac10b023c032562c466a0dc7e (diff)
Midi: Use exceptionCode instead of transactionError
Use of binder::Status exceptionCode is more reliable than transactionError, especially when calling a Java service. Test: builds Bug: 175361278 Change-Id: Iaafb1007f07c7abc22985f0d63f23a0358d6b194
-rw-r--r--media/native/midi/amidi.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/media/native/midi/amidi.cpp b/media/native/midi/amidi.cpp
index 35c4d42a0aa8..923377c8180e 100644
--- a/media/native/midi/amidi.cpp
+++ b/media/native/midi/amidi.cpp
@@ -131,7 +131,7 @@ static media_status_t AMIDI_getDeviceInfo(const AMidiDevice *device,
MidiDeviceInfo deviceInfo;
Status txResult = device->server->getDeviceInfo(&deviceInfo);
if (!txResult.isOk()) {
- ALOGE("AMIDI_getDeviceInfo transaction error: %d", txResult.transactionError());
+ ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
return AMEDIA_ERROR_UNKNOWN;
}
@@ -253,7 +253,7 @@ static media_status_t AMIDI_openPort(const AMidiDevice *device, int32_t portNumb
? device->server->openOutputPort(portToken, portNumber, &ufd)
: device->server->openInputPort(portToken, portNumber, &ufd);
if (!txResult.isOk()) {
- ALOGE("AMIDI_openPort transaction error: %d", txResult.transactionError());
+ ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
return AMEDIA_ERROR_UNKNOWN;
}
@@ -282,7 +282,7 @@ static void AMIDI_closePort(AMIDI_Port *port) {
Status txResult = port->device->server->closePort(port->binderToken);
if (!txResult.isOk()) {
- ALOGE("Transaction error closing MIDI port:%d", txResult.transactionError());
+ ALOGE("%s server exception code: %d", __func__, txResult.exceptionCode());
}
delete port;