From 9ed2cee8de1d853d098009b10d3dec84944b3be4 Mon Sep 17 00:00:00 2001 From: Amin Hassani Date: Fri, 13 Nov 2020 18:40:35 -0800 Subject: update_engine: Don't keep pointer to SystemState available objects These objects are available thorugh SystemState. No need to keep pointer to them in various classes (OmahaRequestBuilderXml in this case). This makes testing/debugging easier because there will be one central location for getting pointers to these values. BUG=b:171829801 TEST=cros_workon_make --board reef --test update_engine Change-Id: I02a36afdc7dcb00e02b1a61263141745afc7fb26 Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2543814 Tested-by: Amin Hassani Reviewed-by: Jae Hoon Kim Commit-Queue: Amin Hassani --- common/dynamic_partition_control_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common/dynamic_partition_control_interface.h') diff --git a/common/dynamic_partition_control_interface.h b/common/dynamic_partition_control_interface.h index 7c2d0b0c..f47958df 100644 --- a/common/dynamic_partition_control_interface.h +++ b/common/dynamic_partition_control_interface.h @@ -26,6 +26,7 @@ #include "update_engine/common/action.h" #include "update_engine/common/cleanup_previous_update_action_delegate.h" #include "update_engine/common/error_code.h" +#include "update_engine/common/prefs_interface.h" #include "update_engine/update_metadata.pb.h" namespace chromeos_update_engine { @@ -42,7 +43,6 @@ struct FeatureFlag { }; class BootControlInterface; -class PrefsInterface; class DynamicPartitionControlInterface { public: -- cgit v1.2.3