From 39c7fa9ffe7d86ac87e56ef8db5bae6580064e53 Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Mon, 24 Aug 2020 10:15:47 -0700 Subject: Fix API for C compatibility In https://android-review.googlesource.com/c/platform/system/core/+/1224544 when we introduced a default argument to androidSetThreadPriority(), we broke C compatibility with this API, and with the header file in general. We fix this up by instead introducing a new method that takes three arguments. This gets this header file compiling for C again, and keeps this particular API C compatible. Any C++ callers of the three argument version of androidSetThreadPriority() will need to switch to using androidSetThreadPriorityAndPolicy(). Although since this was a recent change, we believe there is only one such user, which we are fixing at the same time. Test: TreeHugger Bug: 165009705 Change-Id: Iab0b7e6c91a8e32a17ba1b186fd0c2fe96b601e4 --- libutils/include/utils/AndroidThreads.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'libutils/include/utils/AndroidThreads.h') diff --git a/libutils/include/utils/AndroidThreads.h b/libutils/include/utils/AndroidThreads.h index 3c30a2a85..cdb5442ae 100644 --- a/libutils/include/utils/AndroidThreads.h +++ b/libutils/include/utils/AndroidThreads.h @@ -78,9 +78,12 @@ extern void androidSetCreateThreadFunc(android_create_thread_fn func); // should be one of the ANDROID_PRIORITY constants. Returns INVALID_OPERATION // if the priority set failed, else another value if just the group set failed; // in either case errno is set. Thread ID zero means current thread. +// This is equivalent to androidSetThreadPriorityAndPolicy(tid, prio, true); +extern int androidSetThreadPriority(pid_t tid, int prio); + // Parameter "change_policy" indicates if sched policy should be changed. It needs // not be checked again if the change is done elsewhere like activity manager. -extern int androidSetThreadPriority(pid_t tid, int prio, bool change_policy = true); +extern int androidSetThreadPriorityAndPolicy(pid_t tid, int prio, bool change_policy); // Get the current priority of a particular thread. Returns one of the // ANDROID_PRIORITY constants or a negative result in case of error. -- cgit v1.2.3