From 306f8b571302dc9977d6ecd4aeb130ee9ee6dfdc Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Thu, 19 Dec 2019 16:32:00 -0800 Subject: libutils: sp lh comparison w/ pointer Perhaps the better question is, why have I 100s of times, typed "ASSERT_NE(nullptr, foo)" for sp<> foo, and got a compiler error and then change it to "foo.get()". This CL so we can stop wasting cycles with that error. Fixes: 147842528 Test: libutils_test Change-Id: Id63b29d2a1ff3077201a62b69d864c5a826c47e0 --- libutils/StrongPointer_test.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'libutils/StrongPointer_test.cpp') diff --git a/libutils/StrongPointer_test.cpp b/libutils/StrongPointer_test.cpp index 153cf9683..7b2e37f27 100644 --- a/libutils/StrongPointer_test.cpp +++ b/libutils/StrongPointer_test.cpp @@ -56,3 +56,18 @@ TEST(StrongPointer, move) { } ASSERT_TRUE(isDeleted) << "foo was leaked!"; } + +TEST(StrongPointer, NullptrComparison) { + sp foo; + ASSERT_EQ(foo, nullptr); + ASSERT_EQ(nullptr, foo); +} + +TEST(StrongPointer, PointerComparison) { + bool isDeleted; + sp foo = new SPFoo(&isDeleted); + ASSERT_EQ(foo.get(), foo); + ASSERT_EQ(foo, foo.get()); + ASSERT_NE(nullptr, foo); + ASSERT_NE(foo, nullptr); +} -- cgit v1.2.3