From 6df45d368a3909637a517ee65bef94deff2e5527 Mon Sep 17 00:00:00 2001 From: Remi NGUYEN VAN Date: Thu, 11 Jun 2020 06:31:14 +0000 Subject: Remove DhcpResults from NetworkStack shared lib Remove the dependency on DhcpResults in moduleutils by moving toStableParcelable to NetworkStack main code, and fromStableParcelable to the test only. Only NetworkStack should be generating DhcpResultsParcelables, and only the NetworkStack should be using DhcpResults at this point (eventually the class would move from frameworks/base/core to NetworkStack). Test: built, flashed, WiFi working Bug: 149403767 Original-Change: https://android-review.googlesource.com/1277444 Merged-In: I093fa48967a48f594b242b1e05e7d481fa9ee529 Change-Id: I093fa48967a48f594b242b1e05e7d481fa9ee529 --- .../net/shared/IpConfigurationParcelableUtil.java | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 common/networkstackclient/src/android/net/shared/IpConfigurationParcelableUtil.java (limited to 'common/networkstackclient/src') diff --git a/common/networkstackclient/src/android/net/shared/IpConfigurationParcelableUtil.java b/common/networkstackclient/src/android/net/shared/IpConfigurationParcelableUtil.java new file mode 100644 index 0000000..e8152cf --- /dev/null +++ b/common/networkstackclient/src/android/net/shared/IpConfigurationParcelableUtil.java @@ -0,0 +1,48 @@ +/* + * Copyright (C) 2020 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package android.net.shared; + +import android.annotation.Nullable; +import android.net.InetAddresses; + +import java.net.InetAddress; + +/** + * Collection of utility methods to convert to and from stable AIDL parcelables for IpClient + * configuration classes. + * @hide + */ +public final class IpConfigurationParcelableUtil { + + /** + * Convert InetAddress to String. + * TODO: have an InetAddressParcelable + */ + public static String parcelAddress(@Nullable InetAddress addr) { + if (addr == null) return null; + return addr.getHostAddress(); + } + + /** + * Convert String to InetAddress. + * TODO: have an InetAddressParcelable + */ + public static InetAddress unparcelAddress(@Nullable String addr) { + if (addr == null) return null; + return InetAddresses.parseNumericAddress(addr); + } +} -- cgit v1.2.3