summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinux Build Service Account <lnxbuild@localhost>2023-06-12 15:15:07 -0700
committerLinux Build Service Account <lnxbuild@localhost>2023-06-12 15:15:07 -0700
commite041de1afe487da9d57b70bed45a98b6549b514a (patch)
tree8f66e127312b6786bf1a79d7c050f3a006e8000a
parent4b1a56904ffaeaba1beb00b8449d88625879232e (diff)
parente89544e1efd33104a190828766c596855dcacd0a (diff)
Merge e89544e1efd33104a190828766c596855dcacd0a on remote branch
Change-Id: I2dad8526815cf3c46eb15ba56031adef473f5746
-rw-r--r--camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp21
-rw-r--r--tv/input/aidl/android/hardware/tv/input/ITvInput.aidl5
-rw-r--r--tv/input/aidl/android/hardware/tv/input/ITvInputCallback.aidl5
-rw-r--r--wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp28
4 files changed, 38 insertions, 21 deletions
diff --git a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp
index f8d301f081..aee53664b0 100644
--- a/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp
+++ b/camera/provider/aidl/vts/VtsAidlHalCameraProvider_TargetTest.cpp
@@ -2063,18 +2063,17 @@ TEST_P(CameraAidlTest, process10BitColorSpaceRequests) {
TEST_P(CameraAidlTest, processZoomSettingsOverrideRequests) {
const int32_t kFrameCount = 5;
const int32_t kTestCases = 2;
- const bool kOverrideSequence[kTestCases][kFrameCount] = {
- // ZOOM, ZOOM, ZOOM, ZOOM, ZOOM;
- { true, true, true, true, true },
- // OFF, OFF, ZOOM, ZOOM, OFF;
- { false, false, true, true, false } };
+ const bool kOverrideSequence[kTestCases][kFrameCount] = {// ZOOM, ZOOM, ZOOM, ZOOM, ZOOM;
+ {true, true, true, true, true},
+ // OFF, ZOOM, ZOOM, ZOOM, OFF;
+ {false, true, true, true, false}};
const bool kExpectedOverrideResults[kTestCases][kFrameCount] = {
- // All resuls should be overridden except the last one. The last result's
- // zoom doesn't have speed-up.
- { true, true, true, true, false },
- // Because we require at least 2 frames speed-up, request #1, #2 and #3
- // will be overridden.
- { true, true, true, false, false } };
+ // All resuls should be overridden except the last one. The last result's
+ // zoom doesn't have speed-up.
+ {true, true, true, true, false},
+ // Because we require at least 1 frame speed-up, request #1, #2 and #3
+ // will be overridden.
+ {true, true, true, false, false}};
for (int i = 0; i < kTestCases; i++) {
processZoomSettingsOverrideRequests(kFrameCount, kOverrideSequence[i],
diff --git a/tv/input/aidl/android/hardware/tv/input/ITvInput.aidl b/tv/input/aidl/android/hardware/tv/input/ITvInput.aidl
index cbaf0663b6..c63e0aca0f 100644
--- a/tv/input/aidl/android/hardware/tv/input/ITvInput.aidl
+++ b/tv/input/aidl/android/hardware/tv/input/ITvInput.aidl
@@ -98,6 +98,11 @@ interface ITvInput {
* detected from the stream based on whether or not they are enabled by
* {@link #setTvMessageEnabled(int, int, TvMessageEventType, boolean)}.
*
+ * This queue is expected to already contain the message data before calling
+ * {@link android.hardware.tv.input.ITvInputCallback#notifyTvMessageEvent}.
+ * The HAL implementation is expected to have already created the queue
+ * before the notification callback is called for the first time.
+ *
* @param deviceId The ID of the device that contains the stream to get the queue for.
* @param streamId THe ID of the stream to get the queue for.
* @return The descriptor of the TV message queue.
diff --git a/tv/input/aidl/android/hardware/tv/input/ITvInputCallback.aidl b/tv/input/aidl/android/hardware/tv/input/ITvInputCallback.aidl
index 2c7e32f29d..a3afd41fd5 100644
--- a/tv/input/aidl/android/hardware/tv/input/ITvInputCallback.aidl
+++ b/tv/input/aidl/android/hardware/tv/input/ITvInputCallback.aidl
@@ -39,6 +39,11 @@ interface ITvInputCallback {
* the device that sent the message should be contained in
* {@link android.hardware.tv.input.TvMessage#groupId}
*
+ * Invoking this callback for the first time immediately triggers
+ * {@link android.hardware.tv.input.ITvInput#getTvMessageQueueDesc}. It is
+ * expected for the queue to be ready with
+ * the relevant messages for the event before this callback is called.
+ *
* @param event Event passed to the client.
*/
void notifyTvMessageEvent(in TvMessageEvent event);
diff --git a/wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp b/wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp
index 288f20acf4..f12d873f0c 100644
--- a/wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp
+++ b/wifi/aidl/vts/functional/wifi_sta_iface_aidl_test.cpp
@@ -24,6 +24,7 @@
#include <android/binder_status.h>
#include <binder/IServiceManager.h>
#include <binder/ProcessState.h>
+#include <cutils/properties.h>
#include "wifi_aidl_test_utils.h"
@@ -98,16 +99,23 @@ TEST_P(WifiStaIfaceAidlTest, GetFeatureSet) {
*/
// @VsrTest = 5.3.12
TEST_P(WifiStaIfaceAidlTest, CheckApfIsSupported) {
- // It is not required to check the vendor API level is at least U here
- // because the Wi-Fi AIDL interface is launched with Android U(VSR-14).
- // TODO: Add wavier list to the chipsets that doesn't support APF.
- EXPECT_TRUE(isFeatureSupported(IWifiStaIface::FeatureSetMask::APF));
- StaApfPacketFilterCapabilities apf_caps = {};
- EXPECT_TRUE(wifi_sta_iface_->getApfPacketFilterCapabilities(&apf_caps).isOk());
- // The APF version must be 4 and the usable memory must be at least
- // 1024 bytes.
- EXPECT_EQ(apf_caps.version, 4);
- EXPECT_GE(apf_caps.maxLength, 1024);
+ int vendor_api_level = property_get_int32("ro.vendor.api_level", 0);
+ // Before VSR 14, APF support is optional.
+ if (vendor_api_level < __ANDROID_API_U__) {
+ if (!isFeatureSupported(IWifiStaIface::FeatureSetMask::APF)) {
+ GTEST_SKIP() << "APF packet filter capabilities are not supported.";
+ }
+ StaApfPacketFilterCapabilities apf_caps = {};
+ EXPECT_TRUE(wifi_sta_iface_->getApfPacketFilterCapabilities(&apf_caps).isOk());
+ } else {
+ EXPECT_TRUE(isFeatureSupported(IWifiStaIface::FeatureSetMask::APF));
+ StaApfPacketFilterCapabilities apf_caps = {};
+ EXPECT_TRUE(wifi_sta_iface_->getApfPacketFilterCapabilities(&apf_caps).isOk());
+ // The APF version must be 4 and the usable memory must be at least
+ // 1024 bytes.
+ EXPECT_EQ(apf_caps.version, 4);
+ EXPECT_GE(apf_caps.maxLength, 1024);
+ }
}
/*