SF: Add mStateLock for getDefaultDisplayDeviceLocked function

- 'getDefaultDisplayDeviceLocked' requires exclusive
  holding of mutex 'mStateLock'
- remove dead code function 'getCurrentVsyncSource'

CRs-Fixed: 3370040
Change-Id: Ia3d6c707839f02fa1fa4f5a33299c0e2aa5f507d

2 files changed, 1 insertions, 13 deletions

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 0699ae0108..bc19446747 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -2441,21 +2441,10 @@ nsecs_t SurfaceFlinger::getVsyncPeriodFromHWC() const {
     return 0;
 }
 
-sp<DisplayDevice> SurfaceFlinger::getCurrentVsyncSource() {
-    std::lock_guard<std::recursive_mutex> lockVsync(mVsyncLock);
-
-    if (mNextVsyncSource) {
-        return mNextVsyncSource;
-    } else if (mActiveVsyncSource) {
-        return mActiveVsyncSource;
-    }
-
-    return getDefaultDisplayDeviceLocked();
-}
-
 nsecs_t SurfaceFlinger::getVsyncPeriodFromHWCcb() {
     std::lock_guard<std::recursive_mutex> lockVsync(mVsyncLock);
 
+    Mutex::Autolock lock(mStateLock);
     auto display = getDefaultDisplayDeviceLocked();
     if (mNextVsyncSource) {
         display = mNextVsyncSource;
diff --git a/services/surfaceflinger/SurfaceFlinger.h b/services/surfaceflinger/SurfaceFlinger.h
index add68af3c1..c41d7ab816 100644
--- a/services/surfaceflinger/SurfaceFlinger.h
+++ b/services/surfaceflinger/SurfaceFlinger.h
@@ -1122,7 +1122,6 @@ private:
      */
     nsecs_t getVsyncPeriodFromHWC() const REQUIRES(mStateLock);
     nsecs_t getVsyncPeriodFromHWCcb();
-    sp<DisplayDevice> getCurrentVsyncSource();
 
     void setHWCVsyncEnabled(PhysicalDisplayId id, hal::Vsync enabled) {
         mLastHWCVsyncState = enabled;