From 35ecb89a8aa68f24d2e991df5bb9964ad15075dc Mon Sep 17 00:00:00 2001 From: y Date: Fri, 13 Apr 2018 11:25:12 -0700 Subject: AAPT: Modified StringPool uniqueness detection b/77862560 detected that when converting an apk to binary using aapt2, all resource ids of attributes that have been replaced with resource identifiers become set to the identifier of the first attribute. This is because the attribute names are all empty because the names are not necessary since the resource ids are present. The empty attribute names all map to the same string pool reference and cause all the ids to be the first empty string into the string pool. Bug: 77862560 Test: Converted apk in listed bug from proto to binary and observed correct resource ids and correct badging. Change-Id: I635c13cd1ad7a395fe40a57198cfe5ec91602d01 --- tools/aapt2/StringPool_test.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'tools/aapt2/StringPool_test.cpp') diff --git a/tools/aapt2/StringPool_test.cpp b/tools/aapt2/StringPool_test.cpp index 58a03de60f93..5f7d3d6b1d03 100644 --- a/tools/aapt2/StringPool_test.cpp +++ b/tools/aapt2/StringPool_test.cpp @@ -61,6 +61,17 @@ TEST(StringPoolTest, DoNotInsertNewDuplicateString) { EXPECT_THAT(pool.size(), Eq(1u)); } +TEST(StringPoolTest, DoNotDedupeSameStringDifferentPriority) { + StringPool pool; + + StringPool::Ref ref_a = pool.MakeRef("wut", StringPool::Context(1)); + StringPool::Ref ref_b = pool.MakeRef("wut", StringPool::Context(2)); + + EXPECT_THAT(*ref_a, Eq("wut")); + EXPECT_THAT(*ref_b, Eq("wut")); + EXPECT_THAT(pool.size(), Eq(2u)); +} + TEST(StringPoolTest, MaintainInsertionOrderIndex) { StringPool pool; @@ -292,7 +303,6 @@ TEST(StringPoolTest, Flatten) { } } - TEST(StringPoolTest, MaxEncodingLength) { StdErrDiagnostics diag; using namespace android; // For NO_ERROR on Windows. -- cgit v1.2.3