From 564084cbdbe4e540af199b9d3890fb33c29320e3 Mon Sep 17 00:00:00 2001 From: Hall Liu Date: Wed, 11 Nov 2020 16:53:04 -0800 Subject: Move usage of Runnable::run to TelephonyUtils Using Runnable::run in com.android.internal.telephony from this directory will conflict with any usages from frameworks/opt/telephony since the compiles apparently scopes method references at the package level. Move it to TelephonyUtils (which is in the .util sub-package) to avoid the conflict. Bug: 156779270 Test: build Change-Id: I3471162eecde869aea66533de0355b3214859098 --- telephony/common/com/android/internal/telephony/CarrierAppUtils.java | 3 ++- .../common/com/android/internal/telephony/util/TelephonyUtils.java | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'telephony/common') diff --git a/telephony/common/com/android/internal/telephony/CarrierAppUtils.java b/telephony/common/com/android/internal/telephony/CarrierAppUtils.java index e57b03098758..fa918195e94e 100644 --- a/telephony/common/com/android/internal/telephony/CarrierAppUtils.java +++ b/telephony/common/com/android/internal/telephony/CarrierAppUtils.java @@ -32,6 +32,7 @@ import android.util.ArrayMap; import android.util.Log; import com.android.internal.annotations.VisibleForTesting; +import com.android.internal.telephony.util.TelephonyUtils; import java.util.ArrayList; import java.util.List; @@ -318,7 +319,7 @@ public final class CarrierAppUtils { String[] packageNames = new String[enabledCarrierPackages.size()]; enabledCarrierPackages.toArray(packageNames); permissionManager.grantDefaultPermissionsToEnabledCarrierApps(packageNames, - UserHandle.of(userId), Runnable::run, isSuccess -> { }); + UserHandle.of(userId), TelephonyUtils.DIRECT_EXECUTOR, isSuccess -> { }); } } catch (PackageManager.NameNotFoundException e) { Log.w(TAG, "Could not reach PackageManager", e); diff --git a/telephony/common/com/android/internal/telephony/util/TelephonyUtils.java b/telephony/common/com/android/internal/telephony/util/TelephonyUtils.java index 7736473feafb..02d741011220 100644 --- a/telephony/common/com/android/internal/telephony/util/TelephonyUtils.java +++ b/telephony/common/com/android/internal/telephony/util/TelephonyUtils.java @@ -34,6 +34,7 @@ import java.io.PrintWriter; import java.util.Collections; import java.util.List; import java.util.concurrent.CountDownLatch; +import java.util.concurrent.Executor; import java.util.concurrent.TimeUnit; import java.util.function.Supplier; @@ -44,6 +45,8 @@ public final class TelephonyUtils { public static boolean IS_USER = "user".equals(android.os.Build.TYPE); public static boolean IS_DEBUGGABLE = SystemProperties.getInt("ro.debuggable", 0) == 1; + public static final Executor DIRECT_EXECUTOR = Runnable::run; + /** * Verify that caller holds {@link android.Manifest.permission#DUMP}. * -- cgit v1.2.3