From eb4dd08ec132f83745b8b28fa7da58eb4478b5b9 Mon Sep 17 00:00:00 2001 From: Yang Ni Date: Thu, 24 Mar 2016 09:40:32 -0700 Subject: Added CloseGuard for BaseObj Bug: 27719830 To turn on warnings, apps have to add to their Activity.onCreate() method the following code. StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder() .detectLeakedClosableObjects() .penaltyLog() .build()); For Slang generated ScriptC derived classes, we assume their constructors won't throw exceptions after calling the ScriptC constructor. In addition, ScriptIntrinsic derived classes do not seem to throw exceptions in their constructors either. Therefore, we can leave the guard.open() call in the Script constructor. This may be only an approximation, but allows us to add CloseGuard for script objects without making changes to slang. Change-Id: I77ed45239a60b85af5c811dee6c124fb53da9060 --- rs/java/android/renderscript/Sampler.java | 1 + 1 file changed, 1 insertion(+) (limited to 'rs/java/android/renderscript/Sampler.java') diff --git a/rs/java/android/renderscript/Sampler.java b/rs/java/android/renderscript/Sampler.java index a4edbb50ac10..5c4bae99ba8f 100644 --- a/rs/java/android/renderscript/Sampler.java +++ b/rs/java/android/renderscript/Sampler.java @@ -51,6 +51,7 @@ public class Sampler extends BaseObj { Sampler(long id, RenderScript rs) { super(id, rs); + guard.open("destroy"); } /** -- cgit v1.2.3