From 6419ebff5c553a87ff30f3e298b68519f82420e0 Mon Sep 17 00:00:00 2001 From: Leon Scroggins III Date: Mon, 27 Apr 2020 15:31:21 -0400 Subject: Fix .equals call in ImageDecoder Bug: 154954875 Bug: 143231863 Test: I93b01cb60a8c76110ea2ff4250d0048512629d8d I9229039b752bafa9a9b85b914a62093dff1eec34 switched from "==" to ".equals", but it did not take into account that Uri#getScheme() can return null. Switch around the .equals check so that it is called on SCHEME_CONTENT, which will never be null. Change-Id: I0df5d2407a32fad0e21e597697af293fbc2fb315 Merged-In: I0df5d2407a32fad0e21e597697af293fbc2fb315 --- graphics/java/android/graphics/ImageDecoder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'graphics') diff --git a/graphics/java/android/graphics/ImageDecoder.java b/graphics/java/android/graphics/ImageDecoder.java index 83432c362672..97b448aa8ff0 100644 --- a/graphics/java/android/graphics/ImageDecoder.java +++ b/graphics/java/android/graphics/ImageDecoder.java @@ -270,7 +270,7 @@ public final class ImageDecoder implements AutoCloseable { public ImageDecoder createImageDecoder(boolean preferAnimation) throws IOException { AssetFileDescriptor assetFd = null; try { - if (mUri.getScheme().equals(ContentResolver.SCHEME_CONTENT)) { + if (ContentResolver.SCHEME_CONTENT.equals(mUri.getScheme())) { assetFd = mResolver.openTypedAssetFileDescriptor(mUri, "image/*", null); } else { -- cgit v1.2.3