diff options
-rw-r--r-- | cmds/incident_helper/src/TextParserBase.h | 2 | ||||
-rw-r--r-- | cmds/incident_helper/src/ih_util.h | 4 | ||||
-rw-r--r-- | cmds/incidentd/src/IncidentService.h | 2 | ||||
-rw-r--r-- | cmds/incidentd/src/Privacy.h | 2 | ||||
-rw-r--r-- | cmds/incidentd/src/Reporter.h | 2 | ||||
-rw-r--r-- | cmds/incidentd/src/Section.cpp | 2 | ||||
-rw-r--r-- | libs/incident/include/android/os/IncidentReportArgs.h | 2 | ||||
-rw-r--r-- | tools/incident_report/printer.h | 2 |
8 files changed, 9 insertions, 9 deletions
diff --git a/cmds/incident_helper/src/TextParserBase.h b/cmds/incident_helper/src/TextParserBase.h index 784c181d9741..a6074e71c035 100644 --- a/cmds/incident_helper/src/TextParserBase.h +++ b/cmds/incident_helper/src/TextParserBase.h @@ -30,7 +30,7 @@ class TextParserBase { public: String8 name; - TextParserBase(String8 name) : name(name) {}; + explicit TextParserBase(String8 name) : name(name) {}; virtual ~TextParserBase() {}; virtual status_t Parse(const int in, const int out) const = 0; diff --git a/cmds/incident_helper/src/ih_util.h b/cmds/incident_helper/src/ih_util.h index c02a3493724a..09dc8e6fdbfc 100644 --- a/cmds/incident_helper/src/ih_util.h +++ b/cmds/incident_helper/src/ih_util.h @@ -109,7 +109,7 @@ double toDouble(const std::string& s); class Reader { public: - Reader(const int fd); + explicit Reader(const int fd); ~Reader(); bool readLine(std::string* line); @@ -162,7 +162,7 @@ private: class Message { public: - Message(Table* table); + explicit Message(Table* table); ~Message(); // Reconstructs the typical proto message by adding its message fields. diff --git a/cmds/incidentd/src/IncidentService.h b/cmds/incidentd/src/IncidentService.h index 6252ad295224..c63a183b70b9 100644 --- a/cmds/incidentd/src/IncidentService.h +++ b/cmds/incidentd/src/IncidentService.h @@ -97,7 +97,7 @@ private: // ================================================================================ class IncidentService : public BnIncidentManager { public: - IncidentService(const sp<Looper>& handlerLooper); + explicit IncidentService(const sp<Looper>& handlerLooper); virtual ~IncidentService(); virtual Status reportIncident(const IncidentReportArgs& args); diff --git a/cmds/incidentd/src/Privacy.h b/cmds/incidentd/src/Privacy.h index a3df4903de45..a0159d9a8649 100644 --- a/cmds/incidentd/src/Privacy.h +++ b/cmds/incidentd/src/Privacy.h @@ -83,7 +83,7 @@ public: static PrivacySpec new_spec(int dest); private: - PrivacySpec(uint8_t dest) : dest(dest) {} + explicit PrivacySpec(uint8_t dest) : dest(dest) {} }; } // namespace incidentd diff --git a/cmds/incidentd/src/Reporter.h b/cmds/incidentd/src/Reporter.h index 45fd9443e9d0..2a3abd7b4d97 100644 --- a/cmds/incidentd/src/Reporter.h +++ b/cmds/incidentd/src/Reporter.h @@ -89,7 +89,7 @@ public: ReportRequestSet batch; Reporter(); // PROD must use this constructor. - Reporter(const char* directory); // For testing purpose only. + explicit Reporter(const char* directory); // For testing purpose only. virtual ~Reporter(); // Run the report as described in the batch and args parameters. diff --git a/cmds/incidentd/src/Section.cpp b/cmds/incidentd/src/Section.cpp index 10d226822331..32ec1ba90cda 100644 --- a/cmds/incidentd/src/Section.cpp +++ b/cmds/incidentd/src/Section.cpp @@ -415,7 +415,7 @@ struct WorkerThreadData : public virtual RefBase { bool workerDone; status_t workerError; - WorkerThreadData(const WorkerThreadSection* section); + explicit WorkerThreadData(const WorkerThreadSection* section); virtual ~WorkerThreadData(); }; diff --git a/libs/incident/include/android/os/IncidentReportArgs.h b/libs/incident/include/android/os/IncidentReportArgs.h index c56f689b7419..ee1e33c43b89 100644 --- a/libs/incident/include/android/os/IncidentReportArgs.h +++ b/libs/incident/include/android/os/IncidentReportArgs.h @@ -40,7 +40,7 @@ const uint8_t DEST_AUTOMATIC = 200; class IncidentReportArgs : public Parcelable { public: IncidentReportArgs(); - explicit IncidentReportArgs(const IncidentReportArgs& that); + IncidentReportArgs(const IncidentReportArgs& that); virtual ~IncidentReportArgs(); virtual status_t writeToParcel(Parcel* out) const; diff --git a/tools/incident_report/printer.h b/tools/incident_report/printer.h index ed93fa19542c..63e276b367ca 100644 --- a/tools/incident_report/printer.h +++ b/tools/incident_report/printer.h @@ -22,7 +22,7 @@ class Out { public: - Out(int fd); + explicit Out(int fd); ~Out(); void printf(const char* format, ...); |