diff options
| author | Satoshi Sanno <satoshi.sanno@sony.com> | 2019-05-29 16:39:50 +0900 |
|---|---|---|
| committer | Amin Shaikh <ashaikh@google.com> | 2019-07-03 01:09:16 +0000 |
| commit | 3756b09130c1167a4dcac1e3bb05b81c73bc6adb (patch) | |
| tree | 80e0647ab6ec606722b596eccc323f78174d9e6d /opengl/tests/gl_basic/gl_basic.cpp | |
| parent | fcd34bb87dcf3fcf4c62f398514e2a2349abe6de (diff) | |
Unregister BroadcastReceiver of SystemUIDialog when it is dismissed
Symptom:
The number of registered BroadcastReceiver increases each time
SystemUIDialog is shown.
This is a leak of BroadcastReceiver.
Root cause:
SystemUIDialog#registerDismissListener(Dialog dialog) registers
a BroadcastReceiver.
But it never unregisters the BroadcastReceiver.
It had been unregistered when the dialog was dismissed previously.
But the unregistration process seems to have been erased by mistake
at refactoring.
Solution:
The unregistration process is added to registerDismissListener() again.
It sets the dialog's OnDismissListener to unregister the
BroadcastReceiver when the dialog is dismissed.
And, SystemUIDialog unregisters the BroadcastReceiver without using
registerDismissListener() to make its setOnDismissListener() available
to clients.
Bug: 134916873
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/SystemUIDialogTest.java
Change-Id: Ic41ac46997362ce585819e660c398b47e6685eaf
Diffstat (limited to 'opengl/tests/gl_basic/gl_basic.cpp')
0 files changed, 0 insertions, 0 deletions