diff options
author | Leon Scroggins <scroggo@google.com> | 2020-01-22 23:04:23 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2020-01-22 23:04:23 +0000 |
commit | e609b0c82a202e553ceae23b116b0bd699e7549a (patch) | |
tree | a0c24e54cce57c8b9e694435adfc9cf2462a3f11 | |
parent | b44e3d7201747cb6d48baf95d741797b459eb99a (diff) | |
parent | f8e41c5fc2539b223a435929150d9547ab531be3 (diff) |
Merge "Make getDataSpace fail instead of crash on recycled"
-rw-r--r-- | native/graphics/jni/bitmap.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/native/graphics/jni/bitmap.cpp b/native/graphics/jni/bitmap.cpp index 3d0fd254f9a8..b8eb543ff835 100644 --- a/native/graphics/jni/bitmap.cpp +++ b/native/graphics/jni/bitmap.cpp @@ -33,10 +33,14 @@ int AndroidBitmap_getInfo(JNIEnv* env, jobject jbitmap, int32_t AndroidBitmap_getDataSpace(JNIEnv* env, jobject jbitmap) { if (NULL == env || NULL == jbitmap) { - return ADATASPACE_UNKNOWN; // Or return a real error? + return ADATASPACE_UNKNOWN; } android::graphics::Bitmap bitmap(env, jbitmap); + if (!bitmap.isValid()) { + return ADATASPACE_UNKNOWN; + } + return bitmap.getDataSpace(); } |