diff options
author | Paul Duffin <paulduffin@google.com> | 2017-02-07 15:04:10 +0000 |
---|---|---|
committer | Paul Duffin <paulduffin@google.com> | 2017-02-08 11:55:39 +0000 |
commit | ca4964ccbef5f2c85855fc14577c7c25d0e0588d (patch) | |
tree | 943851d59bf0846528feca4893e94b423f228d91 | |
parent | 80f42edfc7333d8a2a3d8fa529b85ed6763f8cc0 (diff) |
Replace com.android.internal.util.Predicate with java.util.function.Predicate
Bug: 35089332
Bug: 30188076
Test: make checkbuild
Change-Id: I0a5b4bf520fc39b59d8d790b01e9cff0d54e6d21
-rw-r--r-- | cmds/uiautomator/library/core-src/com/android/uiautomator/core/InteractionController.java | 4 | ||||
-rw-r--r-- | core/java/android/view/AccessibilityInteractionController.java | 4 | ||||
-rw-r--r-- | core/java/android/view/View.java | 14 | ||||
-rw-r--r-- | core/java/android/view/ViewGroup.java | 4 | ||||
-rw-r--r-- | core/java/android/widget/DayPickerViewPager.java | 4 | ||||
-rw-r--r-- | core/java/android/widget/ListView.java | 2 | ||||
-rw-r--r-- | core/java/com/android/internal/widget/WatchHeaderListView.java | 3 | ||||
-rw-r--r-- | services/core/java/com/android/server/hdmi/HdmiCecController.java | 10 | ||||
-rw-r--r-- | test-runner/src/com/android/internal/util/Predicate.java (renamed from core/java/com/android/internal/util/Predicate.java) | 0 | ||||
-rw-r--r-- | test-runner/src/com/android/internal/util/Predicates.java (renamed from core/java/com/android/internal/util/Predicates.java) | 1 | ||||
-rw-r--r-- | test-runner/tests/src/com/android/internal/util/PredicatesTest.java (renamed from core/tests/utiltests/src/com/android/internal/util/PredicatesTest.java) | 0 |
11 files changed, 22 insertions, 24 deletions
diff --git a/cmds/uiautomator/library/core-src/com/android/uiautomator/core/InteractionController.java b/cmds/uiautomator/library/core-src/com/android/uiautomator/core/InteractionController.java index 73e46f1775c2..28a5646abb33 100644 --- a/cmds/uiautomator/library/core-src/com/android/uiautomator/core/InteractionController.java +++ b/cmds/uiautomator/library/core-src/com/android/uiautomator/core/InteractionController.java @@ -32,8 +32,6 @@ import android.view.MotionEvent.PointerCoords; import android.view.MotionEvent.PointerProperties; import android.view.accessibility.AccessibilityEvent; -import com.android.internal.util.Predicate; - import java.util.ArrayList; import java.util.List; import java.util.concurrent.TimeoutException; @@ -261,7 +259,7 @@ class InteractionController { } /** - * Returns a Runnable for use in {@link #runAndWaitForEvents(Runnable, Predicate, long) to + * Returns a Runnable for use in {@link #runAndWaitForEvents(Runnable, AccessibilityEventFilter, long) to * perform a click. * * @param x coordinate diff --git a/core/java/android/view/AccessibilityInteractionController.java b/core/java/android/view/AccessibilityInteractionController.java index 4ff4840df453..77e9f0f2aa74 100644 --- a/core/java/android/view/AccessibilityInteractionController.java +++ b/core/java/android/view/AccessibilityInteractionController.java @@ -42,7 +42,6 @@ import android.view.accessibility.IAccessibilityInteractionConnectionCallback; import com.android.internal.R; import com.android.internal.os.SomeArgs; -import com.android.internal.util.Predicate; import java.util.ArrayList; import java.util.HashMap; @@ -51,6 +50,7 @@ import java.util.LinkedList; import java.util.List; import java.util.Map; import java.util.Queue; +import java.util.function.Predicate; /** * Class for managing accessibility interactions initiated from the system @@ -1205,7 +1205,7 @@ final class AccessibilityInteractionController { } @Override - public boolean apply(View view) { + public boolean test(View view) { if (view.getId() == mViewId && isShown(view)) { mInfos.add(view.createAccessibilityNodeInfo()); } diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index ee979844bd20..f44f9238454f 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -115,7 +115,6 @@ import android.widget.FrameLayout; import android.widget.ScrollBarDrawable; import com.android.internal.R; -import com.android.internal.util.Predicate; import com.android.internal.view.TooltipPopup; import com.android.internal.view.menu.MenuBuilder; import com.android.internal.widget.ScrollBarUtils; @@ -140,6 +139,7 @@ import java.util.Locale; import java.util.Map; import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Predicate; /** * <p> @@ -9325,7 +9325,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, final int id = mID; return root.findViewByPredicateInsideOut(this, new Predicate<View>() { @Override - public boolean apply(View t) { + public boolean test(View t) { return t.mNextFocusForwardId == id; } }); @@ -20002,7 +20002,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback, * @hide */ protected View findViewByPredicateTraversal(Predicate<View> predicate, View childToSkip) { - if (predicate.apply(this)) { + if (predicate.test(this)) { return this; } return null; @@ -24448,20 +24448,20 @@ public class View implements Drawable.Callback, KeyEvent.Callback, } } - private class MatchIdPredicate implements Predicate<View> { + private static class MatchIdPredicate implements Predicate<View> { public int mId; @Override - public boolean apply(View view) { + public boolean test(View view) { return (view.mID == mId); } } - private class MatchLabelForPredicate implements Predicate<View> { + private static class MatchLabelForPredicate implements Predicate<View> { private int mLabeledId; @Override - public boolean apply(View view) { + public boolean test(View view) { return (view.mLabelForId == mLabeledId); } } diff --git a/core/java/android/view/ViewGroup.java b/core/java/android/view/ViewGroup.java index 36beaaae864a..d107d616b541 100644 --- a/core/java/android/view/ViewGroup.java +++ b/core/java/android/view/ViewGroup.java @@ -57,7 +57,6 @@ import android.view.animation.LayoutAnimationController; import android.view.animation.Transformation; import com.android.internal.R; -import com.android.internal.util.Predicate; import java.util.ArrayList; import java.util.Arrays; @@ -66,6 +65,7 @@ import java.util.Collections; import java.util.HashSet; import java.util.List; import java.util.Map; +import java.util.function.Predicate; /** * <p> @@ -4275,7 +4275,7 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager */ @Override protected View findViewByPredicateTraversal(Predicate<View> predicate, View childToSkip) { - if (predicate.apply(this)) { + if (predicate.test(this)) { return this; } diff --git a/core/java/android/widget/DayPickerViewPager.java b/core/java/android/widget/DayPickerViewPager.java index 94022ae11b6d..a27e0225b54e 100644 --- a/core/java/android/widget/DayPickerViewPager.java +++ b/core/java/android/widget/DayPickerViewPager.java @@ -21,10 +21,10 @@ import android.graphics.drawable.Drawable; import android.util.AttributeSet; import android.view.View; -import com.android.internal.util.Predicate; import com.android.internal.widget.ViewPager; import java.util.ArrayList; +import java.util.function.Predicate; /** * This displays a list of months in a calendar format with selectable days. @@ -138,7 +138,7 @@ class DayPickerViewPager extends ViewPager { @Override protected View findViewByPredicateTraversal(Predicate<View> predicate, View childToSkip) { - if (predicate.apply(this)) { + if (predicate.test(this)) { return this; } diff --git a/core/java/android/widget/ListView.java b/core/java/android/widget/ListView.java index 80780a6fe0f1..46e998af246b 100644 --- a/core/java/android/widget/ListView.java +++ b/core/java/android/widget/ListView.java @@ -49,12 +49,12 @@ import android.view.accessibility.AccessibilityNodeProvider; import android.widget.RemoteViews.RemoteView; import com.android.internal.R; -import com.android.internal.util.Predicate; import com.google.android.collect.Lists; import java.util.ArrayList; import java.util.List; +import java.util.function.Predicate; /* * Implementation Notes: diff --git a/core/java/com/android/internal/widget/WatchHeaderListView.java b/core/java/com/android/internal/widget/WatchHeaderListView.java index 4fd19c37bf47..7e915374ca4f 100644 --- a/core/java/com/android/internal/widget/WatchHeaderListView.java +++ b/core/java/com/android/internal/widget/WatchHeaderListView.java @@ -26,8 +26,7 @@ import android.widget.ListView; import android.widget.HeaderViewListAdapter; import java.util.ArrayList; - -import com.android.internal.util.Predicate; +import java.util.function.Predicate; public class WatchHeaderListView extends ListView { private View mTopPanel; diff --git a/services/core/java/com/android/server/hdmi/HdmiCecController.java b/services/core/java/com/android/server/hdmi/HdmiCecController.java index 4a10f50dde5a..07c3a3871110 100644 --- a/services/core/java/com/android/server/hdmi/HdmiCecController.java +++ b/services/core/java/com/android/server/hdmi/HdmiCecController.java @@ -25,7 +25,6 @@ import android.os.MessageQueue; import android.util.Slog; import android.util.SparseArray; import com.android.internal.util.IndentingPrintWriter; -import com.android.internal.util.Predicate; import com.android.server.hdmi.HdmiAnnotations.IoThreadOnly; import com.android.server.hdmi.HdmiAnnotations.ServiceThreadOnly; import com.android.server.hdmi.HdmiControlService.DevicePollingCallback; @@ -34,6 +33,7 @@ import java.util.ArrayList; import java.util.Date; import java.util.LinkedList; import java.util.List; +import java.util.function.Predicate; import java.util.concurrent.ArrayBlockingQueue; import libcore.util.EmptyArray; import sun.util.locale.LanguageTag; @@ -77,7 +77,7 @@ final class HdmiCecController { // Predicate for whether the given logical address is remote device's one or not. private final Predicate<Integer> mRemoteDeviceAddressPredicate = new Predicate<Integer>() { @Override - public boolean apply(Integer address) { + public boolean test(Integer address) { return !isAllocatedLocalDeviceAddress(address); } }; @@ -85,7 +85,7 @@ final class HdmiCecController { // Predicate whether the given logical address is system audio's one or not private final Predicate<Integer> mSystemAudioAddressPredicate = new Predicate<Integer>() { @Override - public boolean apply(Integer address) { + public boolean test(Integer address) { return HdmiUtils.getTypeFromAddress(address) == Constants.ADDR_AUDIO_SYSTEM; } }; @@ -427,7 +427,7 @@ final class HdmiCecController { switch (iterationStrategy) { case Constants.POLL_ITERATION_IN_ORDER: for (int i = Constants.ADDR_TV; i <= Constants.ADDR_SPECIFIC_USE; ++i) { - if (pickPredicate.apply(i)) { + if (pickPredicate.test(i)) { pollingCandidates.add(i); } } @@ -435,7 +435,7 @@ final class HdmiCecController { case Constants.POLL_ITERATION_REVERSE_ORDER: default: // The default is reverse order. for (int i = Constants.ADDR_SPECIFIC_USE; i >= Constants.ADDR_TV; --i) { - if (pickPredicate.apply(i)) { + if (pickPredicate.test(i)) { pollingCandidates.add(i); } } diff --git a/core/java/com/android/internal/util/Predicate.java b/test-runner/src/com/android/internal/util/Predicate.java index bc6d6b31dd28..bc6d6b31dd28 100644 --- a/core/java/com/android/internal/util/Predicate.java +++ b/test-runner/src/com/android/internal/util/Predicate.java diff --git a/core/java/com/android/internal/util/Predicates.java b/test-runner/src/com/android/internal/util/Predicates.java index c006564f129a..30b8dc6b6ee2 100644 --- a/core/java/com/android/internal/util/Predicates.java +++ b/test-runner/src/com/android/internal/util/Predicates.java @@ -21,6 +21,7 @@ import java.util.Arrays; /** * Predicates contains static methods for creating the standard set of * {@code Predicate} objects. + * @hide */ public class Predicates { diff --git a/core/tests/utiltests/src/com/android/internal/util/PredicatesTest.java b/test-runner/tests/src/com/android/internal/util/PredicatesTest.java index c46ff051dd33..c46ff051dd33 100644 --- a/core/tests/utiltests/src/com/android/internal/util/PredicatesTest.java +++ b/test-runner/tests/src/com/android/internal/util/PredicatesTest.java |