summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Mankoff <mankoff@google.com>2020-05-10 06:00:57 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-05-10 06:00:57 +0000
commitbf8b51e5e88a5608d2967e75f4af73859b89b150 (patch)
treecd1fc8f222a16105df2c67e00407d4caf620ccbd
parent743ec0cb1df5864efdaf82b2a9e7e401c6df3646 (diff)
parentf4f86ddc29e2d617a2f5275d3de6c62badf8cb9b (diff)
Merge "Prevent NPE in PulseExpansionHandler" into rvc-dev am: 6727245a59 am: cb9ffc3d2c am: d230231be8 am: f4f86ddc29
Change-Id: I58954640036ac9e9f303b7cdd29c42f9a8f480ab
-rw-r--r--packages/SystemUI/src/com/android/systemui/statusbar/PulseExpansionHandler.kt21
1 files changed, 13 insertions, 8 deletions
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/PulseExpansionHandler.kt b/packages/SystemUI/src/com/android/systemui/statusbar/PulseExpansionHandler.kt
index 88f148b00cdc..02c98ae2867d 100644
--- a/packages/SystemUI/src/com/android/systemui/statusbar/PulseExpansionHandler.kt
+++ b/packages/SystemUI/src/com/android/systemui/statusbar/PulseExpansionHandler.kt
@@ -121,14 +121,14 @@ constructor(
}
override fun onInterceptTouchEvent(event: MotionEvent): Boolean {
- return maybeStartExpansion(event)
+ return canHandleMotionEvent() && startExpansion(event)
}
- private fun maybeStartExpansion(event: MotionEvent): Boolean {
- if (!wakeUpCoordinator.canShowPulsingHuns || qsExpanded ||
- bouncerShowing) {
- return false
- }
+ private fun canHandleMotionEvent(): Boolean {
+ return !wakeUpCoordinator.canShowPulsingHuns || qsExpanded || bouncerShowing
+ }
+
+ private fun startExpansion(event: MotionEvent): Boolean {
if (velocityTracker == null) {
velocityTracker = VelocityTracker.obtain()
}
@@ -177,9 +177,14 @@ constructor(
}
override fun onTouchEvent(event: MotionEvent): Boolean {
- if (!isExpanding) {
- return maybeStartExpansion(event)
+ if (!canHandleMotionEvent()) {
+ return false
+ }
+
+ if (!isExpanding || event.actionMasked == MotionEvent.ACTION_DOWN) {
+ return startExpansion(event)
}
+
velocityTracker!!.addMovement(event)
val y = event.y