summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Su <dysu@google.com>2020-10-06 16:15:18 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2020-10-06 16:15:18 +0000
commita3e52bf4e492786d3937d8926ea447e310f6ec98 (patch)
tree19da879e5a16b6c4fdd2c1a917a270dd22022297
parent0572a76bc1b5554d97ff9871b72bc359fd48fec5 (diff)
parentb93c97d7a105b46839ad7ec7628ef6593d2b06e4 (diff)
Merge "Migrate existing Build.VERSION.SDK_INT checks to SdkLevelUtil"
-rw-r--r--wifi/tests/src/android/net/wifi/SoftApCapabilityTest.java13
-rw-r--r--wifi/tests/src/android/net/wifi/SoftApConfigurationTest.java8
2 files changed, 10 insertions, 11 deletions
diff --git a/wifi/tests/src/android/net/wifi/SoftApCapabilityTest.java b/wifi/tests/src/android/net/wifi/SoftApCapabilityTest.java
index b9c640cc3980..3c935058787b 100644
--- a/wifi/tests/src/android/net/wifi/SoftApCapabilityTest.java
+++ b/wifi/tests/src/android/net/wifi/SoftApCapabilityTest.java
@@ -16,10 +16,11 @@
package android.net.wifi;
-import android.os.Build;
+import android.net.wifi.util.SdkLevelUtil;
import android.os.Parcel;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assume.assumeTrue;
import androidx.test.filters.SmallTest;
@@ -92,14 +93,12 @@ public class SoftApCapabilityTest {
@Test(expected = IllegalArgumentException.class)
public void testGetSupportedChannelListWithInvalidBand() {
+ assumeTrue(SdkLevelUtil.isAtLeastS());
+
long testSoftApFeature = SoftApCapability.SOFTAP_FEATURE_CLIENT_FORCE_DISCONNECT
| SoftApCapability.SOFTAP_FEATURE_ACS_OFFLOAD;
SoftApCapability capability = new SoftApCapability(testSoftApFeature);
- if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
- capability.getSupportedChannelList(
- SoftApConfiguration.BAND_2GHZ | SoftApConfiguration.BAND_5GHZ);
- } else {
- throw new IllegalArgumentException("API doesn't support in current SDK version");
- }
+ capability.getSupportedChannelList(
+ SoftApConfiguration.BAND_2GHZ | SoftApConfiguration.BAND_5GHZ);
}
}
diff --git a/wifi/tests/src/android/net/wifi/SoftApConfigurationTest.java b/wifi/tests/src/android/net/wifi/SoftApConfigurationTest.java
index 254434b81f8f..7d7d2ba4c880 100644
--- a/wifi/tests/src/android/net/wifi/SoftApConfigurationTest.java
+++ b/wifi/tests/src/android/net/wifi/SoftApConfigurationTest.java
@@ -21,7 +21,7 @@ import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertNull;
import android.net.MacAddress;
-import android.os.Build;
+import android.net.wifi.util.SdkLevelUtil;
import android.os.Parcel;
import androidx.test.filters.SmallTest;
@@ -81,7 +81,7 @@ public class SoftApConfigurationTest {
assertThat(original.getChannel()).isEqualTo(0);
assertThat(original.isHiddenSsid()).isEqualTo(false);
assertThat(original.getMaxNumberOfClients()).isEqualTo(0);
- if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
+ if (SdkLevelUtil.isAtLeastS()) {
assertThat(original.getMacRandomizationSetting())
.isEqualTo(SoftApConfiguration.RANDOMIZATION_PERSISTENT);
}
@@ -137,7 +137,7 @@ public class SoftApConfigurationTest {
.setClientControlByUserEnabled(true)
.setBlockedClientList(testBlockedClientList)
.setAllowedClientList(testAllowedClientList);
- if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
+ if (SdkLevelUtil.isAtLeastS()) {
originalBuilder.setMacRandomizationSetting(SoftApConfiguration.RANDOMIZATION_NONE);
}
SoftApConfiguration original = originalBuilder.build();
@@ -153,7 +153,7 @@ public class SoftApConfigurationTest {
assertThat(original.isClientControlByUserEnabled()).isEqualTo(true);
assertThat(original.getBlockedClientList()).isEqualTo(testBlockedClientList);
assertThat(original.getAllowedClientList()).isEqualTo(testAllowedClientList);
- if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
+ if (SdkLevelUtil.isAtLeastS()) {
assertThat(original.getMacRandomizationSetting())
.isEqualTo(SoftApConfiguration.RANDOMIZATION_NONE);
}