summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZak Cohen <zakcohen@google.com>2019-02-26 14:11:16 -0800
committerZak Cohen <zakcohen@google.com>2019-02-27 23:15:36 +0000
commit8b8766912ce97e48165e11507ed70574a947d9af (patch)
tree15a0825268856f0c9f220898476cc368f436af08
parent63ebfcba5d62de4db9cfeb627ac98a4bc65ef425 (diff)
Properly update remote service when ContentSuggestionsPerUserService is updated.
Test: CTS Change-Id: I6604efb9f7514b2abff28d65ca77da7903d1cbc5
-rw-r--r--services/contentsuggestions/java/com/android/server/contentsuggestions/ContentSuggestionsPerUserService.java16
1 files changed, 10 insertions, 6 deletions
diff --git a/services/contentsuggestions/java/com/android/server/contentsuggestions/ContentSuggestionsPerUserService.java b/services/contentsuggestions/java/com/android/server/contentsuggestions/ContentSuggestionsPerUserService.java
index 385bc6cf3932..a18686da653e 100644
--- a/services/contentsuggestions/java/com/android/server/contentsuggestions/ContentSuggestionsPerUserService.java
+++ b/services/contentsuggestions/java/com/android/server/contentsuggestions/ContentSuggestionsPerUserService.java
@@ -80,12 +80,7 @@ public final class ContentSuggestionsPerUserService extends
@Override // from PerUserSystemService
protected boolean updateLocked(boolean disabled) {
final boolean enabledChanged = super.updateLocked(disabled);
- if (enabledChanged) {
- if (!isEnabledLocked()) {
- // Clear the remote service for the next call
- mRemoteService = null;
- }
- }
+ updateRemoteServiceLocked();
return enabledChanged;
}
@@ -133,6 +128,15 @@ public final class ContentSuggestionsPerUserService extends
}
@GuardedBy("mLock")
+ private void updateRemoteServiceLocked() {
+ if (mRemoteService != null) {
+ mRemoteService.destroy();
+ mRemoteService = null;
+ }
+ }
+
+
+ @GuardedBy("mLock")
@Nullable
private RemoteContentSuggestionsService getRemoteServiceLocked() {
if (mRemoteService == null) {