diff options
author | Aurimas Liutikas <aurimas@google.com> | 2020-11-12 18:29:11 -0800 |
---|---|---|
committer | Aurimas Liutikas <aurimas@google.com> | 2020-11-12 18:30:12 -0800 |
commit | 46a165215b0f389d4f85433bdc8cbd5a31a3f78f (patch) | |
tree | 437cb7495fb6ae0f5631738df64b646e5438c0e6 | |
parent | 83cc1b62f0e0c609a2d191c50c94143fb7ca7f00 (diff) |
Remove legacy style metalava suppression
@SuppressLint("Doclava125") is a legacy way of suppressing
RequiresPermission check. Updating to the new style of suppression
so metalava no longer has to support the legacy mode.
sed -i "s/@SuppressLint(\"Doclava125/@SuppressLint(\"RequiresPermission/" \
core/java/android/app/admin/DevicePolicyManager.java \
core/java/android/hardware/hdmi/HdmiControlManager.java \
core/java/android/hardware/location/ContextHubManager.java \
core/java/android/hardware/usb/UsbDeviceConnection.java \
core/java/android/net/TrafficStats.java \
core/java/android/os/RecoverySystem.java \
core/java/android/os/storage/StorageManager.java \
core/java/android/service/persistentdata/PersistentDataBlockManager.java \
location/java/android/location/LocationManager.java \
media/java/android/media/AudioManager.java \
telecomm/java/android/telecom/TelecomManager.java \
telephony/java/android/telephony/CarrierConfigManager.java \
telephony/java/android/telephony/TelephonyManager.java \
wifi/java/android/net/wifi/RttManager.java \
wifi/java/android/net/wifi/WifiScanner.java
Test: make
Exempt-From-Owner-Approval: No-op change
Merged-In: I6d5df95cfca2950ea86872d2f0afc1ba828841dc
Change-Id: I6d5df95cfca2950ea86872d2f0afc1ba828841dc
14 files changed, 42 insertions, 42 deletions
diff --git a/core/java/android/app/admin/DevicePolicyManager.java b/core/java/android/app/admin/DevicePolicyManager.java index 6fa5a7b1fb65..6edc8ea6a3a6 100644 --- a/core/java/android/app/admin/DevicePolicyManager.java +++ b/core/java/android/app/admin/DevicePolicyManager.java @@ -6680,7 +6680,7 @@ public class DevicePolicyManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public boolean isDeviceManaged() { try { return mService.hasDeviceOwner(); @@ -10392,7 +10392,7 @@ public class DevicePolicyManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public @Nullable CharSequence getDeviceOwnerOrganizationName() { try { return mService.getDeviceOwnerOrganizationName(); diff --git a/core/java/android/hardware/hdmi/HdmiControlManager.java b/core/java/android/hardware/hdmi/HdmiControlManager.java index 4c96c54debc0..f25b06b5dc45 100644 --- a/core/java/android/hardware/hdmi/HdmiControlManager.java +++ b/core/java/android/hardware/hdmi/HdmiControlManager.java @@ -407,7 +407,7 @@ public final class HdmiControlManager { */ @Nullable @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public HdmiClient getClient(int type) { if (mService == null) { return null; @@ -440,7 +440,7 @@ public final class HdmiControlManager { */ @Nullable @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public HdmiPlaybackClient getPlaybackClient() { return (HdmiPlaybackClient) getClient(HdmiDeviceInfo.DEVICE_PLAYBACK); } @@ -458,7 +458,7 @@ public final class HdmiControlManager { */ @Nullable @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public HdmiTvClient getTvClient() { return (HdmiTvClient) getClient(HdmiDeviceInfo.DEVICE_TV); } @@ -476,7 +476,7 @@ public final class HdmiControlManager { * @hide */ @Nullable - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public HdmiAudioSystemClient getAudioSystemClient() { return (HdmiAudioSystemClient) getClient(HdmiDeviceInfo.DEVICE_AUDIO_SYSTEM); } @@ -491,7 +491,7 @@ public final class HdmiControlManager { * @return {@link HdmiSwitchClient} instance. {@code null} on failure. */ @Nullable - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public HdmiSwitchClient getSwitchClient() { return (HdmiSwitchClient) getClient(HdmiDeviceInfo.DEVICE_PURE_CEC_SWITCH); } diff --git a/core/java/android/hardware/location/ContextHubManager.java b/core/java/android/hardware/location/ContextHubManager.java index 1ed791d66f74..d44480796d75 100644 --- a/core/java/android/hardware/location/ContextHubManager.java +++ b/core/java/android/hardware/location/ContextHubManager.java @@ -654,7 +654,7 @@ public final class ContextHubManager { * register a {@link android.hardware.location.ContextHubClientCallback}. */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public int registerCallback(@NonNull Callback callback) { return registerCallback(callback, null); } @@ -688,7 +688,7 @@ public final class ContextHubManager { * register a {@link android.hardware.location.ContextHubClientCallback}. */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public int registerCallback(Callback callback, Handler handler) { synchronized(this) { if (mCallback != null) { @@ -892,7 +892,7 @@ public final class ContextHubManager { * @deprecated Use {@link android.hardware.location.ContextHubClient#close()} to unregister * a {@link android.hardware.location.ContextHubClientCallback}. */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") @Deprecated public int unregisterCallback(@NonNull Callback callback) { synchronized(this) { diff --git a/core/java/android/hardware/usb/UsbDeviceConnection.java b/core/java/android/hardware/usb/UsbDeviceConnection.java index 21634cc544e7..1c35cb66ada8 100644 --- a/core/java/android/hardware/usb/UsbDeviceConnection.java +++ b/core/java/android/hardware/usb/UsbDeviceConnection.java @@ -299,7 +299,7 @@ public class UsbDeviceConnection { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public boolean resetDevice() { return native_reset_device(); } diff --git a/core/java/android/net/TrafficStats.java b/core/java/android/net/TrafficStats.java index 737683050528..4e019cf0732e 100644 --- a/core/java/android/net/TrafficStats.java +++ b/core/java/android/net/TrafficStats.java @@ -301,7 +301,7 @@ public class TrafficStats { * Changes only take effect during subsequent calls to * {@link #tagSocket(Socket)}. */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public static void setThreadStatsUid(int uid) { NetworkManagementSocketTagger.setThreadSocketStatsUid(uid); } @@ -339,7 +339,7 @@ public class TrafficStats { * * @see #setThreadStatsUid(int) */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public static void clearThreadStatsUid() { NetworkManagementSocketTagger.setThreadSocketStatsUid(-1); } diff --git a/core/java/android/os/RecoverySystem.java b/core/java/android/os/RecoverySystem.java index 8cdcd49cb2cc..38e170402ae9 100644 --- a/core/java/android/os/RecoverySystem.java +++ b/core/java/android/os/RecoverySystem.java @@ -422,7 +422,7 @@ public class RecoverySystem { * {@hide} */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public static boolean verifyPackageCompatibility(File compatibilityFile) throws IOException { try (InputStream inputStream = new FileInputStream(compatibilityFile)) { return verifyPackageCompatibility(inputStream); diff --git a/core/java/android/os/storage/StorageManager.java b/core/java/android/os/storage/StorageManager.java index 684ea08ce1a4..648d93431018 100644 --- a/core/java/android/os/storage/StorageManager.java +++ b/core/java/android/os/storage/StorageManager.java @@ -2221,7 +2221,7 @@ public class StorageManager { /** @hide */ @SystemApi @WorkerThread - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public long getAllocatableBytes(@NonNull UUID storageUuid, @RequiresPermission @AllocateFlags int flags) throws IOException { try { @@ -2270,7 +2270,7 @@ public class StorageManager { /** @hide */ @SystemApi @WorkerThread - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void allocateBytes(@NonNull UUID storageUuid, @BytesLong long bytes, @RequiresPermission @AllocateFlags int flags) throws IOException { try { @@ -2320,7 +2320,7 @@ public class StorageManager { /** @hide */ @SystemApi @WorkerThread - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void allocateBytes(FileDescriptor fd, @BytesLong long bytes, @RequiresPermission @AllocateFlags int flags) throws IOException { final File file = ParcelFileDescriptor.getFile(fd); diff --git a/core/java/android/service/persistentdata/PersistentDataBlockManager.java b/core/java/android/service/persistentdata/PersistentDataBlockManager.java index 0bf68b734b8a..8242f4e2c9dc 100644 --- a/core/java/android/service/persistentdata/PersistentDataBlockManager.java +++ b/core/java/android/service/persistentdata/PersistentDataBlockManager.java @@ -90,7 +90,7 @@ public class PersistentDataBlockManager { * * @param data the data to write */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public int write(byte[] data) { try { return sService.write(data); @@ -102,7 +102,7 @@ public class PersistentDataBlockManager { /** * Returns the data block stored on the persistent partition. */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public byte[] read() { try { return sService.read(); @@ -130,7 +130,7 @@ public class PersistentDataBlockManager { * * Returns -1 on error. */ - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public long getMaximumDataBlockSize() { try { return sService.getMaximumDataBlockSize(); diff --git a/media/java/android/media/AudioManager.java b/media/java/android/media/AudioManager.java index 57b853332f3f..107d6565a29e 100755 --- a/media/java/android/media/AudioManager.java +++ b/media/java/android/media/AudioManager.java @@ -3542,8 +3542,8 @@ public class AudioManager { * @deprecated use {@link #abandonAudioFocusRequest(AudioFocusRequest)} */ @SystemApi - @SuppressLint("Doclava125") // no permission enforcement, but only "undoes" what would have been - // done by a matching requestAudioFocus + @SuppressLint("RequiresPermission") // no permission enforcement, but only "undoes" what would + // have been done by a matching requestAudioFocus public int abandonAudioFocus(OnAudioFocusChangeListener l, AudioAttributes aa) { int status = AUDIOFOCUS_REQUEST_FAILED; unregisterAudioFocusRequest(l); @@ -5146,7 +5146,7 @@ public class AudioManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") // FIXME is this still used? + @SuppressLint("RequiresPermission") // FIXME is this still used? public boolean isHdmiSystemAudioSupported() { try { return getService().isHdmiSystemAudioSupported(); diff --git a/telecomm/java/android/telecom/TelecomManager.java b/telecomm/java/android/telecom/TelecomManager.java index fbb1701dd52a..da2d4d82481b 100644 --- a/telecomm/java/android/telecom/TelecomManager.java +++ b/telecomm/java/android/telecom/TelecomManager.java @@ -1228,7 +1228,7 @@ public class TelecomManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public List<PhoneAccountHandle> getPhoneAccountsForPackage() { try { if (isServiceConnected()) { @@ -1356,7 +1356,7 @@ public class TelecomManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void clearPhoneAccounts() { clearAccounts(); } @@ -1366,7 +1366,7 @@ public class TelecomManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void clearAccounts() { try { if (isServiceConnected()) { @@ -1398,7 +1398,7 @@ public class TelecomManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public ComponentName getDefaultPhoneApp() { try { if (isServiceConnected()) { diff --git a/telephony/java/android/telephony/CarrierConfigManager.java b/telephony/java/android/telephony/CarrierConfigManager.java index 2ffc14e4c4f0..0c0943d795f5 100644 --- a/telephony/java/android/telephony/CarrierConfigManager.java +++ b/telephony/java/android/telephony/CarrierConfigManager.java @@ -4782,7 +4782,7 @@ public class CarrierConfigManager { */ @NonNull @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public static PersistableBundle getDefaultConfig() { return new PersistableBundle(sDefaults); } diff --git a/telephony/java/android/telephony/TelephonyManager.java b/telephony/java/android/telephony/TelephonyManager.java index 27aadd56dac5..099e47b90fd2 100644 --- a/telephony/java/android/telephony/TelephonyManager.java +++ b/telephony/java/android/telephony/TelephonyManager.java @@ -4656,7 +4656,7 @@ public class TelephonyManager { * be implemented instead. */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void setVisualVoicemailEnabled(PhoneAccountHandle phoneAccountHandle, boolean enabled){ } @@ -4671,7 +4671,7 @@ public class TelephonyManager { */ @SystemApi @RequiresPermission(android.Manifest.permission.READ_PHONE_STATE) - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public boolean isVisualVoicemailEnabled(PhoneAccountHandle phoneAccountHandle){ return false; } @@ -4690,7 +4690,7 @@ public class TelephonyManager { * @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") @Nullable public Bundle getVisualVoicemailSettings(){ try { @@ -8524,7 +8524,7 @@ public class TelephonyManager { /** @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public int checkCarrierPrivilegesForPackage(String pkgName) { try { ITelephony telephony = getITelephony(); @@ -8540,7 +8540,7 @@ public class TelephonyManager { /** @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public int checkCarrierPrivilegesForPackageAnyPhone(String pkgName) { try { ITelephony telephony = getITelephony(); @@ -8616,7 +8616,7 @@ public class TelephonyManager { /** @hide */ @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void dial(String number) { try { ITelephony telephony = getITelephony(); @@ -8675,7 +8675,7 @@ public class TelephonyManager { */ @Deprecated @SystemApi - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void silenceRinger() { // No-op } diff --git a/wifi/java/android/net/wifi/RttManager.java b/wifi/java/android/net/wifi/RttManager.java index 73c52ab0ab1b..034defb083de 100644 --- a/wifi/java/android/net/wifi/RttManager.java +++ b/wifi/java/android/net/wifi/RttManager.java @@ -173,7 +173,7 @@ public class RttManager { /** @deprecated Use the new {@link android.net.wifi.RttManager#getRttCapabilities()} API.*/ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public Capabilities getCapabilities() { throw new UnsupportedOperationException( "getCapabilities is not supported in the adaptation layer"); diff --git a/wifi/java/android/net/wifi/WifiScanner.java b/wifi/java/android/net/wifi/WifiScanner.java index 94771ac4ad78..4163c88c0418 100644 --- a/wifi/java/android/net/wifi/WifiScanner.java +++ b/wifi/java/android/net/wifi/WifiScanner.java @@ -1239,7 +1239,7 @@ public class WifiScanner { * @param bssidInfos access points to watch */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void configureWifiChange( int rssiSampleSize, /* sample size for RSSI averaging */ int lostApSampleSize, /* samples to confirm AP's loss */ @@ -1273,7 +1273,7 @@ public class WifiScanner { * provided on {@link #stopTrackingWifiChange} */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void startTrackingWifiChange(WifiChangeListener listener) { throw new UnsupportedOperationException(); } @@ -1284,7 +1284,7 @@ public class WifiScanner { * #stopTrackingWifiChange} */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void stopTrackingWifiChange(WifiChangeListener listener) { throw new UnsupportedOperationException(); } @@ -1292,7 +1292,7 @@ public class WifiScanner { /** @hide */ @SystemApi @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void configureWifiChange(WifiChangeSettings settings) { throw new UnsupportedOperationException(); } @@ -1348,7 +1348,7 @@ public class WifiScanner { * also be provided on {@link #stopTrackingBssids} */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void startTrackingBssids(BssidInfo[] bssidInfos, int apLostThreshold, BssidListener listener) { throw new UnsupportedOperationException(); @@ -1359,7 +1359,7 @@ public class WifiScanner { * @param listener same object provided in {@link #startTrackingBssids} */ @Deprecated - @SuppressLint("Doclava125") + @SuppressLint("RequiresPermission") public void stopTrackingBssids(BssidListener listener) { throw new UnsupportedOperationException(); } |