diff options
| author | Shivam Joshi <quic_shivamj@quicinc.com> | 2024-08-01 09:16:06 +0530 |
|---|---|---|
| committer | Shivam Joshi <quic_shivamj@quicinc.com> | 2024-08-02 03:58:12 +0000 |
| commit | 91a5d75808b0068e507706b0a2c53f0c690a196a (patch) | |
| tree | 9ac76b78bc3da2c5dfe1637d28b8201d95158045 | |
| parent | 9c20fb3cc5dbb969797dbc7b5517f81474d010d0 (diff) | |
Codec 2.0: Overload createSyncFence for backward compatibility
The new signature of createSyncFence is not backward compatible
with original one.
In a scenario where vendor code is pointing the older symbol
and system code is pointing the new symbol there is a symbol
mismatch hence causing compilte time error.
Bug: https://partnerissuetracker.corp.google.com/issues/356973032
CRs-Fixed: 3876339
Change-Id: Ibb6c2876bb9b9734cd9ed8f2d98c2c512e154bb3
| -rw-r--r-- | media/codec2/vndk/C2Fence.cpp | 4 | ||||
| -rw-r--r-- | media/codec2/vndk/include/C2FenceFactory.h | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/media/codec2/vndk/C2Fence.cpp b/media/codec2/vndk/C2Fence.cpp index 022d3c21f9..8f16c67b1c 100644 --- a/media/codec2/vndk/C2Fence.cpp +++ b/media/codec2/vndk/C2Fence.cpp @@ -515,6 +515,10 @@ C2Fence _C2FenceFactory::CreateSyncFence(int fenceFd, bool validate) { return C2Fence(p); } +C2Fence _C2FenceFactory::CreateSyncFence(int fenceFd) { + return CreateSyncFence(fenceFd, true); +} + C2Fence _C2FenceFactory::CreateUnorderedMultiSyncFence( const std::vector<int>& fenceFds, c2_status_t *status) { if (status) { diff --git a/media/codec2/vndk/include/C2FenceFactory.h b/media/codec2/vndk/include/C2FenceFactory.h index c71c64adab..25eff9c04f 100644 --- a/media/codec2/vndk/include/C2FenceFactory.h +++ b/media/codec2/vndk/include/C2FenceFactory.h @@ -64,8 +64,13 @@ struct _C2FenceFactory { * \param validate If true, the fence fd will be validated to ensure * it is a valid pending sync fence fd. */ + static C2Fence CreateSyncFence(int fenceFd, bool validate = true); + //Overloading CreateSyncFence for backward compatibility + + static C2Fence CreateSyncFence(int fenceFd); + /* * Create C2Fence from list of sync fence fds, while also merging them to * create a singular fence, which can be used as a backward compatible sync |