summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRex Hoffman <rexhoffman@google.com>2022-11-18 07:18:13 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2022-11-18 07:18:13 +0000
commitf32579b08a2fedeeaf5d2ac82ba6dc1de5a814ba (patch)
treed4fb915aa6f81afdbb58d7d459ed96de17142010
parent688e6960fa1f3ee887c0f8159d6b0af50453028a (diff)
parentc07abe9ad24a10c738ff608f9f4ceb301f642d6d (diff)
Enable new_robolectric am: ebaac47e4e am: c07abe9ad2
Original change: https://googleplex-android-review.googlesource.com/c/platform/build/soong/+/20387913 Change-Id: I57f613dd82abe7fc0132572028c43a44bf00e114 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--android/neverallow.go1
-rw-r--r--java/robolectric.go12
2 files changed, 12 insertions, 1 deletions
diff --git a/android/neverallow.go b/android/neverallow.go
index e3bdd63b2..38d97224b 100644
--- a/android/neverallow.go
+++ b/android/neverallow.go
@@ -155,6 +155,7 @@ func createJavaDeviceForHostRules() []Rule {
"external/guava",
"external/kotlinx.coroutines",
"external/robolectric-shadows",
+ "external/robolectric",
"frameworks/layoutlib",
}
diff --git a/java/robolectric.go b/java/robolectric.go
index f71952172..80be04612 100644
--- a/java/robolectric.go
+++ b/java/robolectric.go
@@ -23,6 +23,8 @@ import (
"android/soong/android"
"android/soong/java/config"
"android/soong/tradefed"
+
+ "github.com/google/blueprint/proptools"
)
func init() {
@@ -63,6 +65,10 @@ type robolectricProperties struct {
// The version number of a robolectric prebuilt to use from prebuilts/misc/common/robolectric
// instead of the one built from source in external/robolectric-shadows.
Robolectric_prebuilt_version *string
+
+ // Use /external/robolectric rather than /external/robolectric-shadows as the version of robolectri
+ // to use. /external/robolectric closely tracks github's master, and will fully replace /external/robolectric-shadows
+ Upstream *bool
}
type robolectricTest struct {
@@ -106,7 +112,11 @@ func (r *robolectricTest) DepsMutator(ctx android.BottomUpMutatorContext) {
if v := String(r.robolectricProperties.Robolectric_prebuilt_version); v != "" {
ctx.AddVariationDependencies(nil, libTag, fmt.Sprintf(robolectricPrebuiltLibPattern, v))
} else {
- ctx.AddVariationDependencies(nil, libTag, robolectricCurrentLib)
+ if proptools.Bool(r.robolectricProperties.Upstream) {
+ ctx.AddVariationDependencies(nil, libTag, robolectricCurrentLib+"_upstream")
+ } else {
+ ctx.AddVariationDependencies(nil, libTag, robolectricCurrentLib)
+ }
}
ctx.AddVariationDependencies(nil, libTag, robolectricDefaultLibs...)