From 7cebf835f310650f67b254295a685918681656fc Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 12 Aug 2020 14:25:41 -0700 Subject: Various coverage improvements. Mostly from extra test cases, but also: * Move the fgets size < 0 assertion into fgets. * Use ELF aliases for strtoq/strtouq rather than duplicating code. * Don't check uname() succeeded, since it can't fail. Test: treehugger Change-Id: I2e6b3b88b0a3eb16bd68be68b9bc9f40d8043291 --- tests/netinet_ether_test.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'tests/netinet_ether_test.cpp') diff --git a/tests/netinet_ether_test.cpp b/tests/netinet_ether_test.cpp index faa3db47f..af020ec93 100644 --- a/tests/netinet_ether_test.cpp +++ b/tests/netinet_ether_test.cpp @@ -34,7 +34,7 @@ TEST(netinet_ether, ether_aton__ether_ntoa) { TEST(netinet_ether, ether_aton_r__ether_ntoa_r) { ether_addr addr; memset(&addr, 0, sizeof(addr)); - ether_addr* a = ether_aton_r("12:34:56:78:9a:bc", &addr); + ether_addr* a = ether_aton_r("12:34:56:78:9a:Bc", &addr); ASSERT_EQ(&addr, a); ASSERT_EQ(0x12, addr.ether_addr_octet[0]); ASSERT_EQ(0x34, addr.ether_addr_octet[1]); @@ -49,3 +49,11 @@ TEST(netinet_ether, ether_aton_r__ether_ntoa_r) { ASSERT_EQ(buf, p); ASSERT_STREQ("12:34:56:78:9a:bc", buf); } + +TEST(netinet_ether, ether_aton_r_failures) { + ether_addr addr; + ASSERT_TRUE(ether_aton_r("12:34:56:78:9a;bc", &addr) == nullptr); + ASSERT_TRUE(ether_aton_r("12:34:56:78:9a:bc ", &addr) == nullptr); + ASSERT_TRUE(ether_aton_r("g2:34:56:78:9a:bc ", &addr) == nullptr); + ASSERT_TRUE(ether_aton_r("1G:34:56:78:9a:bc ", &addr) == nullptr); +} -- cgit v1.2.3