From a2f1319a8941ae52c98594824b919c08eeb0ecd1 Mon Sep 17 00:00:00 2001 From: Alex Light Date: Wed, 3 Feb 2021 18:19:03 -0800 Subject: Add text-profile support for multiple ICs Text profile inline-cache support was limited to methods with only a single invoke. This extends support so it is instead based on the receiver type and supports an arbitrary number of invokes. It does assume that all invokes of the same receivers should have the same ICs. This enables us to create text profiles that can survive most common edits to the underlying java language files. IC lines are of the following format <> := {CLASS}(,{CLASS})* <> := \[{CLASS}{CLASS_GROUP} <> := {PROFILE_FLAGS}{CLASS}->{METHOD}\+{IC_GROUP}* This means a typical line might look like: ``` HLTestInline;->inlineTriplePolymorphic(LSuper;LSecret;LSecret;)I+[LSuper;LSubA;,LSubB;,LSubC;[LSecret;LSubB;,LSubC; ``` Note that old style single-invoke IC lines are still supported as well and their format has not changed. Updated --dump-classes-and-methods to dump ICs using this format. Note that it will combine ICs for different pcs with the same target so it is possible to construct a profile where the 'profile -> dump -> profile' operation is not idempotent. Any profile coming from a text-dump will be idempotent under this transform. Test: ./test.py --host Bug: 168941430 Change-Id: I69ba3b312caa7ca454487aaeb49862e393de3a4a --- test/ProfileTestMultiDex/Main.java | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) (limited to 'test/ProfileTestMultiDex/Main.java') diff --git a/test/ProfileTestMultiDex/Main.java b/test/ProfileTestMultiDex/Main.java index 978cb2c6fd..a84cb98543 100644 --- a/test/ProfileTestMultiDex/Main.java +++ b/test/ProfileTestMultiDex/Main.java @@ -46,26 +46,58 @@ class TestInline { public int noInlineCache(Super s) { return s.getValue(); } + + public int inlineMultiMonomorphic(Super s, Secret sec) { + return s.getValue() + sec.getIdentity(); + } + + public int inlineMultiPolymorphic(Super s, Secret sec) { + return s.getValue() + sec.getIdentity(); + } + + public int inlineTriplePolymorphic(Super s, Secret sec, Secret thr) { + return s.getValue() + sec.getIdentity() + thr.getIdentity(); + } + + public int inlineMultiMegamorphic(Super s, Secret sec) { + return s.getValue() + sec.getIdentity(); + } + + public int inlineMultiMissingTypes(Super s, Secret sec) { + return s.getValue() + sec.getIdentity(); + } + + public int noInlineCacheMulti(Super s, Secret sec) { + return s.getValue() + sec.getIdentity(); + } +} + +abstract class Secret { + abstract int getIdentity(); } -abstract class Super { +abstract class Super extends Secret { abstract int getValue(); } class SubA extends Super { int getValue() { return 42; } + int getIdentity() { return 24; } } class SubB extends Super { int getValue() { return 38; }; + int getIdentity() { return 83; } } class SubD extends Super { int getValue() { return 20; }; + int getIdentity() { return 2; }; } class SubE extends Super { int getValue() { return 16; }; + int getIdentity() { return 61; }; } // Add a class with lots of methods so we can test profile guided compilation triggers. -- cgit v1.2.3