From 07f5e96d63121165b82635b6b7fa187ec3920612 Mon Sep 17 00:00:00 2001 From: Martin Stjernholm Date: Thu, 27 May 2021 20:54:22 +0100 Subject: Fix bitrot in the libnativebridge tests. - Bitrot 1: NativeBridge2Signal_test stopped working when version 3 was added in https://r.android.com/234059. - Bitrot 2: The code path that PreInitializeNativeBridgeFail1_test tested was removed completely when missing app data directory was allowed in https://r.android.com/1208629, so delete the test. - Use cc_test_library for the dynamic test libs so they are installed in the test directory rather than in system/lib(64). - Use test_per_src since native_bridge.cc doesn't support reloading the native bridge implementation lib after unloading. - Add a custom script to run the tests and a preupload check that the script is run. (Configuring atest for these tests still TBD in b/189484095 - test_per_src is a complication.) Cherry-picked from https://r.android.com/1721410. Test: art/libnativebridge/tests/runtests.sh Bug: 122710865 Bug: 189484095 Change-Id: Ib2b387e1d858127ca4bb44c548a5105ea8b838d8 Merged-In: Ib2b387e1d858127ca4bb44c548a5105ea8b838d8 --- libnativebridge/tests/CodeCacheCreate_test.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'libnativebridge/tests/CodeCacheCreate_test.cpp') diff --git a/libnativebridge/tests/CodeCacheCreate_test.cpp b/libnativebridge/tests/CodeCacheCreate_test.cpp index 58270c43dd..1bd309c5c8 100644 --- a/libnativebridge/tests/CodeCacheCreate_test.cpp +++ b/libnativebridge/tests/CodeCacheCreate_test.cpp @@ -23,9 +23,10 @@ namespace android { // Tests that the bridge initialization creates the code_cache if it doesn't -// exists. +// exist. TEST_F(NativeBridgeTest, CodeCacheCreate) { - // Make sure that code_cache does not exists + // Make sure that code_cache does not exist + rmdir(kCodeCache); struct stat st; ASSERT_EQ(-1, stat(kCodeCache, &st)); ASSERT_EQ(ENOENT, errno); -- cgit v1.2.3