From 11edec7e7e8ac93f826d687b644fe700fab68993 Mon Sep 17 00:00:00 2001 From: David Brazdil Date: Thu, 24 Mar 2016 12:40:52 +0000 Subject: ART: Loosen a GraphChecker rule on Boolean inputs GraphChecker tries to verify that Boolean inputs are properly typed. This is non-trivial in the presence of simplifying optimizations which capitalize on the fact that a Boolean value is internally represented as an integer. This patch removes the test from GraphChecker. Bug: 27625564 Change-Id: Ic61ea2193765b4578550538e965ca4f80fa4b287 --- compiler/optimizing/graph_visualizer.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'compiler/optimizing/graph_visualizer.cc') diff --git a/compiler/optimizing/graph_visualizer.cc b/compiler/optimizing/graph_visualizer.cc index 3a9d242df2..4b5b919b68 100644 --- a/compiler/optimizing/graph_visualizer.cc +++ b/compiler/optimizing/graph_visualizer.cc @@ -418,6 +418,20 @@ class HGraphVisualizerPrinter : public HGraphDelegateVisitor { StartAttributeStream("intrinsic") << invoke->GetIntrinsic(); } + void VisitInstanceFieldGet(HInstanceFieldGet* iget) OVERRIDE { + StartAttributeStream("field_name") << PrettyField(iget->GetFieldInfo().GetFieldIndex(), + iget->GetFieldInfo().GetDexFile(), + /* with type */ false); + StartAttributeStream("field_type") << iget->GetFieldType(); + } + + void VisitInstanceFieldSet(HInstanceFieldSet* iset) OVERRIDE { + StartAttributeStream("field_name") << PrettyField(iset->GetFieldInfo().GetFieldIndex(), + iset->GetFieldInfo().GetDexFile(), + /* with type */ false); + StartAttributeStream("field_type") << iset->GetFieldType(); + } + void VisitUnresolvedInstanceFieldGet(HUnresolvedInstanceFieldGet* field_access) OVERRIDE { StartAttributeStream("field_type") << field_access->GetFieldType(); } -- cgit v1.2.3